Skip to content

chore: sync react localization from platform-localization#274

Merged
cameronapak merged 2 commits into
mainfrom
chore/localization-sync-react-20260629-4fa6992
Jul 7, 2026
Merged

chore: sync react localization from platform-localization#274
cameronapak merged 2 commits into
mainfrom
chore/localization-sync-react-20260629-4fa6992

Conversation

@platform-localization-pr-bot

@platform-localization-pr-bot platform-localization-pr-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Automated localization sync from platform-localization.

  • Platform: React
  • Source ref: 4fa6992cc909a1115d57ce53d4f0af76ef230692
  • Workflow: Distribute React Localization

Greptile Summary

This automated localization sync removes two i18n keys from packages/ui/src/i18n/locales/en.json, but both keys remain in active use within bible-version-picker.tsx, leaving the component referencing undefined translations.

  • noLanguageSearchResults is removed but still rendered at line 923 of bible-version-picker.tsx — users who get no language search results will see a missing-key fallback instead of the intended message.
  • languageSearchAriaLabel is removed but still applied as the aria-label of the language search input at line 988 — screen readers will receive either the raw key string or an empty label, breaking accessibility.

Confidence Score: 3/5

The sync drops two translation keys that are still referenced in a shipped component, causing a broken empty-state message and a missing aria-label on the language search input in production.

Both removed keys are actively consumed by bible-version-picker.tsx. The missing noLanguageSearchResults key breaks the no-results UI for language search, and the missing languageSearchAriaLabel key removes the accessible label from the search input, degrading screen-reader support immediately on merge.

packages/ui/src/i18n/locales/en.json — the two deleted keys must be restored (or the corresponding references in bible-version-picker.tsx must be removed first).

Important Files Changed

Filename Overview
packages/ui/src/i18n/locales/en.json Removes noLanguageSearchResults and languageSearchAriaLabel keys that are still actively used in bible-version-picker.tsx, breaking the no-results message and the language search input's aria-label.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["bible-version-picker.tsx"] -->|"t('noLanguageSearchResults')"| B["en.json lookup"]
    A -->|"t('languageSearchAriaLabel')"| B
    B -->|"Key removed by this PR"| C["❌ Missing key fallback"]
    C --> D["Empty-results paragraph shows raw key or empty string"]
    C --> E["Language search input loses aria-label (accessibility broken)"]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["bible-version-picker.tsx"] -->|"t('noLanguageSearchResults')"| B["en.json lookup"]
    A -->|"t('languageSearchAriaLabel')"| B
    B -->|"Key removed by this PR"| C["❌ Missing key fallback"]
    C --> D["Empty-results paragraph shows raw key or empty string"]
    C --> E["Language search input loses aria-label (accessibility broken)"]
Loading

Fix All in Claude Code Fix All in Cursor Fix All in Codex

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/ui/src/i18n/locales/en.json:43
**Missing i18n keys still referenced by `bible-version-picker.tsx`**

Both `noLanguageSearchResults` and `languageSearchAriaLabel` are removed here, but `packages/ui/src/components/bible-version-picker.tsx` still calls `t('noLanguageSearchResults')` at line 923 and `t('languageSearchAriaLabel')` at line 988. Depending on how the i18n library handles missing keys, the language search input will render either a raw key string or an empty `aria-label` (breaking screen-reader accessibility), and the empty-results paragraph will show a missing-key fallback instead of the intended human-readable message.

Reviews (2): Last reviewed commit: "Merge branch 'main' into chore/localizat..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1299c25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread packages/ui/src/i18n/locales/en.json
@camrun91 camrun91 self-requested a review July 7, 2026 17:01

@camrun91 camrun91 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go now

@cameronapak cameronapak merged commit 51bd802 into main Jul 7, 2026
6 checks passed
@cameronapak cameronapak deleted the chore/localization-sync-react-20260629-4fa6992 branch July 7, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants