chore: sync react localization from platform-localization#274
Merged
Conversation
|
camrun91
approved these changes
Jul 7, 2026
camrun91
left a comment
Collaborator
There was a problem hiding this comment.
This is good to go now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated localization sync from
platform-localization.4fa6992cc909a1115d57ce53d4f0af76ef230692Distribute React LocalizationGreptile Summary
This automated localization sync removes two i18n keys from
packages/ui/src/i18n/locales/en.json, but both keys remain in active use withinbible-version-picker.tsx, leaving the component referencing undefined translations.noLanguageSearchResultsis removed but still rendered at line 923 ofbible-version-picker.tsx— users who get no language search results will see a missing-key fallback instead of the intended message.languageSearchAriaLabelis removed but still applied as thearia-labelof the language search input at line 988 — screen readers will receive either the raw key string or an empty label, breaking accessibility.Confidence Score: 3/5
The sync drops two translation keys that are still referenced in a shipped component, causing a broken empty-state message and a missing aria-label on the language search input in production.
Both removed keys are actively consumed by
bible-version-picker.tsx. The missingnoLanguageSearchResultskey breaks the no-results UI for language search, and the missinglanguageSearchAriaLabelkey removes the accessible label from the search input, degrading screen-reader support immediately on merge.packages/ui/src/i18n/locales/en.json — the two deleted keys must be restored (or the corresponding references in bible-version-picker.tsx must be removed first).
Important Files Changed
noLanguageSearchResultsandlanguageSearchAriaLabelkeys that are still actively used inbible-version-picker.tsx, breaking the no-results message and the language search input's aria-label.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["bible-version-picker.tsx"] -->|"t('noLanguageSearchResults')"| B["en.json lookup"] A -->|"t('languageSearchAriaLabel')"| B B -->|"Key removed by this PR"| C["❌ Missing key fallback"] C --> D["Empty-results paragraph shows raw key or empty string"] C --> E["Language search input loses aria-label (accessibility broken)"]%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A["bible-version-picker.tsx"] -->|"t('noLanguageSearchResults')"| B["en.json lookup"] A -->|"t('languageSearchAriaLabel')"| B B -->|"Key removed by this PR"| C["❌ Missing key fallback"] C --> D["Empty-results paragraph shows raw key or empty string"] C --> E["Language search input loses aria-label (accessibility broken)"]Prompt To Fix All With AI
Reviews (2): Last reviewed commit: "Merge branch 'main' into chore/localizat..." | Re-trigger Greptile