Conversation
xepozz
commented
Apr 7, 2023
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
============================================
- Coverage 88.44% 88.36% -0.09%
+ Complexity 95 93 -2
============================================
Files 13 13
Lines 277 275 -2
============================================
- Hits 245 243 -2
Misses 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Overall the change looks OK. Need a CHANGELOG for it. Also, it's is backwards compatibility breaking one. |
| if ($this->currentUser->isGuest()) { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
It's break logic of Yii Auth package in Authentication middleware: https://github.com/yiisoft/auth/blob/27a4e9ac4e89d810625c73f1578586d2ecdc9c27/src/Middleware/Authentication.php#L48C43-L48C53
|
It shouldn't be merged yet because it cause bugs in authentication. |