EXT-1270 Add --mon-key option with the same meaning as the --ic-key/--grpc-key options #30296
Conversation
Run Extra TestsRun additional tests for this PR. You can customize:
|
|
🟢 |
There was a problem hiding this comment.
Pull request overview
This PR adds the --mon-key command-line option to specify a separate private key file for monitoring HTTPS configuration, aligning with existing --ic-key and --grpc-key options. This change allows users to maintain separate certificate and private key files for monitoring SSL/TLS configuration, rather than requiring both to be in the same file.
- Added
MonitoringPrivateKeyFilefield to configuration protobuf and related structures - Updated SSL context creation logic to support optional separate key file parameter
- Refactored certificate loading from inline file reading to path-based configuration
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ydb/library/actors/http/http_proxy_ssl.h | Modified CreateServerContext to support optional separate key file, falling back to certificate file when key is empty |
| ydb/core/protos/config.proto | Added MonitoringPrivateKeyFile field to TMonitoringConfig message |
| ydb/core/mon/mon.h | Added PrivateKeyFile field to config struct with documentation comments |
| ydb/core/mon/mon.cpp | Updated to pass certificate and private key file paths to HTTP proxy; modified Secure flag logic |
| ydb/core/driver_lib/run/run.cpp | Changed from reading certificate file inline to passing file path to monitoring config |
| ydb/core/driver_lib/run/config_parser.h | Added MonitoringPrivateKeyFile field to config parser options |
| ydb/core/driver_lib/run/config_parser.cpp | Added --mon-key command-line option and updated certificate handling to use file paths |
| ydb/core/config/init/init_impl.h | Added MonitoringPrivateKeyFile field and --mon-key option, removed inline file reading validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
For all other TLS connections we have several options: --xx-key and --xx-cert: separate options for certificate and key. The aim of this PR is to do the same for monitoring options.