fix(npm): inherit global minimal age gate in scopes#7214
Open
ychampion wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Resolves #7192.
Scoped
npmMinimalAgeGateentries currently get their own default of1d, so an unset scoped gate doesn't fall back to the globalnpmMinimalAgeGate. That makesnpmMinimalAgeGate: 0ineffective for scoped packages unless every scope repeats the same value.How did you fix it?
Scoped
npmMinimalAgeGatenow defaults tonull, which lets the existing npm helper fall back to the global setting unless a scope explicitly sets its own gate.The regression covers both the config output from the issue and the scoped install behavior when the global gate is disabled.
Validation
yarn build:cliyarn test:integration npmMinimalAgeGateyarn typecheck:allyarn test:lintyarn constraintsyarn version checkgit diff --checkChecklist