Skip to content

Skeleton#191

Merged
yamcodes merged 11 commits into
mainfrom
skeleton
Sep 23, 2025
Merged

Skeleton#191
yamcodes merged 11 commits into
mainfrom
skeleton

Conversation

@yamcodes

@yamcodes yamcodes commented Sep 23, 2025

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • The video demo now displays a poster image while loading, improving perceived performance and visual continuity.
    • The video renders at a fixed width for more consistent layout and alignment across screens.
    • Existing playback behavior (auto-play, loop, muted, plays inline) remains unchanged.
  • Style

    • Visual presentation refined by constraining video dimensions and providing a fallback image for a smoother, more polished experience.

- Added VideoDemo component
- Added arkenv-video.mov
- Updated home page
- Removed StackBlitz demo component
- Removed middleware for StackBlitz
- Removed env var and sdk dependency
- Reduced dark mode shadow intensity
- Wrapped video in a button
- Allows play on click
- Removed embed params
- Removed duplicated source
- Use env var for github repo
- Computed once, avoids repetition
- Added github url breakdown util
- Added aria-label to the play button for the demo video to improve accessibility.
- Added a poster image for the video demo.
- Set the video width to 958 pixels for better display.
@cursor

cursor Bot commented Sep 23, 2025

Copy link
Copy Markdown

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 26.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@changeset-bot

changeset-bot Bot commented Sep 23, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ab4fae4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Sep 23, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
arkenv Ready Ready Preview Comment Sep 23, 2025 5:55pm

@coderabbitai

coderabbitai Bot commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Added width and poster attributes to a video element in apps/www/components/page/video-demo.tsx. No changes to logic, events, or structure.

Changes

Cohort / File(s) Summary
Video component attribute update
apps/www/components/page/video-demo.tsx
Added width={958} and poster="/assets/demo.png" to the video element; playback behavior unchanged (autoPlay, loop, muted, playsInline).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibble code like clover leaves,
A poster blooms before the stream weaves,
Width set snug, a tidy scene—
Pixels lined, precise and clean.
Loop and hush, inline delight,
Carrot-commit shipped just right. 🥕🎬

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check ❓ Inconclusive The title "Skeleton" is too vague and does not summarize the main change in this PR. The changes add width and poster attributes to a video element in apps/www/components/page/video-demo.tsx, which the title does not convey. A more descriptive title would help reviewers quickly understand the intent. Rename the PR to a concise, descriptive title such as "video-demo: add poster image and fixed width to demo video". Update the PR description to mention the changed file and the added width and poster attributes so reviewers see the intent immediately. After renaming, re-run checks or request review to confirm clarity.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch skeleton

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the www Improvements or additions to arkenv.js.org label Sep 23, 2025

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
apps/www/components/page/video-demo.tsx (1)

21-21: Aria label doesn’t match action.

Click opens StackBlitz, not “play video”.

Apply this diff:

-        aria-label="Play demo video"
+        aria-label="Open interactive demo in a new tab"
🧹 Nitpick comments (2)
apps/www/components/page/video-demo.tsx (2)

31-31: Add MP4 fallback for broader browser support.

MOV/quicktime often fails on Chromium. Provide MP4 first, then MOV.

Use this source order:

<source src="/assets/demo.mp4" type="video/mp4" />
<source src="/assets/demo.mov" type="video/quicktime" />

27-29: Avoid fixed width — make the video responsive

Replace width={958} with responsive Tailwind constraints to prevent horizontal overflow on small screens.

File: apps/www/components/page/video-demo.tsx — apply:

-          width={958}
-          poster="/assets/demo.png"
-          className="block max-h-[600px] sm:max-h-[1000px] object-contain"
+          poster="/assets/demo.png"
+          className="block w-full max-w-[958px] max-h-[600px] sm:max-h-[1000px] object-contain"

Optional wrapper constraint:

-        className="rounded-lg overflow-hidden border border-fd-border shadow-lg bg-black/5 dark:bg-black/20 cursor-pointer"
+        className="w-full max-w-[958px] rounded-lg overflow-hidden border border-fd-border shadow-lg bg-black/5 dark:bg-black/20 cursor-pointer"

Verified assets: apps/www/public/assets/demo.png, apps/www/public/assets/demo.mov

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e719c2 and ab4fae4.

⛔ Files ignored due to path filters (1)
  • apps/www/public/assets/demo.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • apps/www/components/page/video-demo.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test-build
🔇 Additional comments (1)
apps/www/components/page/video-demo.tsx (1)

28-28: LGTM: poster improves perceived loading.

@yamcodes
yamcodes merged commit 31fbc77 into main Sep 23, 2025
8 checks passed
@yamcodes
yamcodes deleted the skeleton branch September 23, 2025 17:59
This was referenced Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

www Improvements or additions to arkenv.js.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant