allows user to change the background color#1
Open
maxwell04-wq wants to merge 1 commit intoyaleqc:masterfrom
Open
allows user to change the background color#1maxwell04-wq wants to merge 1 commit intoyaleqc:masterfrom
maxwell04-wq wants to merge 1 commit intoyaleqc:masterfrom
Conversation
seunomonije
requested changes
Mar 31, 2021
Member
seunomonije
left a comment
There was a problem hiding this comment.
Thank you for your PR! You're the first one!
A few notes:
- Why label this PR "allows user to change the background color"?
- Rather than creating a new folder in the rot directory of the repo, just add on to the existing structure.
| @@ -0,0 +1 @@ | |||
| This is a random sentence - I guess! No newline at end of file | |||
Member
There was a problem hiding this comment.
This is a good sentence, but shouldn't it be located in part4-changing_the_code/people/ and not in the root directory of the repository?
| @@ -0,0 +1 @@ | |||
| # Name: Mahnoor Fatima No newline at end of file | |||
Member
There was a problem hiding this comment.
If you look at part4-changing_the_code/printer.py, you'll see where I put my name. Rather than creating a new file in a new directory, all you need to do is add to the existing file!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.