"Via wp-cli" inaccurately attributed

[krogsgard]

I made edits to Stream settings via the WordPress admin, but "via wp-cli" shows up in the Author column: https://cloudup.com/cBSj671Af84

Not sure what causes it, but thought I'd let you know!

[frankiejarrett]

@krogsgard Just curious what version of Stream you have installed and when you installed it, because we fixed an issue just like this in #441.

[krogsgard]

@fjarrett I installed it this morning, so I'm running 1.4.3

[westonruter]

Humm. So author_meta for a Stream record currently includes an item:

'is_wp_cli'       => defined( 'WP_CLI' ),

In #448 we've refactored Stream authorship to introduce a concept of agent, with WP-CLI being one such agent, and WP Cron being another.

The problem in #441 was that the author_meta was not getting deserialized, and so $author_meta remained a string, and the is_wp_cli associative array index got casted to an integer (0), resulting in it returning the first letter of the string, and thus a true value and making the list table return show "via WP-CLI".

@krogsgard any chance you'd be able to share the underlying author_meta Stream meta (from the DB) for that record?

[krogsgard]

@westonruter Here's a sample author_meta from a Stream Record showing wp-cli:

s:192:"a:5:{s:10:"user_email";s:19:"briankrogsgardsnotrealemail@gmail.com";s:12:"display_name";s:15:"Brian Krogsgard";s:10:"user_login";s:9:"krogsgard";s:15:"user_role_label";s:13:"Administrator";s:9:"is_wp_cli";b:0;}"

[westonruter]

Excellent. Thanks, @krogsgard. So this shows that the underlying data is correct. It's just it's not deserializing the value properly. Though, as said before, this was previously addressed in #441, so it's strange that the issue has resurfaced. We'll investigate.

[shadyvb]

@krogsgard @westonruter If I'm not mistaken, the autor_meta value is not correct, it begins with : s:192:"..... which means the value will ultimately be de-serialized into a string not an array.

[shadyvb]

@westonruter We are already serializing meta values on insertion, and recently we added serializing before insertion , combined with WordPress behavior of double serializing stuff and not deserializing them properly will probably be the cause of this.

Solution here would probably be removing the double serializing and it should work normally. Will issue a PR shortly for this.

[westonruter]

@shadyvb You can see from the author_meta that @krogsgard provided above that the DB value in the stream meta is not double serialized.

[westonruter]

I am so wrong. It is getting double-serialized, as @shady pointed out: s:192:"a:5:{s:10:"user_. It's a serialized string containing the serialized array.