feat: enforce async def run() for all skills #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skills now require async def run() instead of def run() - PythonSkill.from_source() validates and rejects sync def run() - InProcessExecutor.SkillsNamespace handles async via run_coroutine_threadsafe - SubprocessExecutor.SkillsProxy handles async via ThreadPoolExecutor - SubprocessConfig.ipc_timeout defaults to None (unlimited) for long-running skills - All test skill definitions updated to use async def run()
…EPS env var - Add CONTAINER_DEPS env var in to_docker_config() when config.deps is set - Read CONTAINER_DEPS in server.py and populate deps_store on startup - Fix typo: self._config -> self.config in get_configured_deps()
- Add async def run() validation to from_file() (was only in from_source()) - Add CONTAINER_DEPS env var handling to Redis mode in server.py - Simplify invoke() method - remove dead sync code path since async is now enforced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
async def run()for all skills (syncdef run()now rejected)Changes
PythonSkill.from_source()andfrom_file()now validate via AST that skills useasync def run()SkillsNamespace.invoke()usesrun_coroutine_threadsafe()for thread-safe async executionSkillsProxy.invoke()in subprocess kernel usesThreadPoolExecutorwhen event loop is runningasync def run()in all examples