Skip to content

Drupal 8.8.0.#89

Merged
tormi merged 10 commits intomasterfrom
feature/drupal-8.8
Dec 9, 2019
Merged

Drupal 8.8.0.#89
tormi merged 10 commits intomasterfrom
feature/drupal-8.8

Conversation

@tormi
Copy link
Member

@tormi tormi commented Dec 6, 2019

This PR updates the project template to Drupal 8.8. Steps to test out:

  1. clone the repo & cd to the project root: git clone git@github.com:wunderio/drupal-project.git && cd drupal-project
  2. select the feature branch: git checkout feature/drupal-8.8
  3. perform lando start

@tormi
Copy link
Member Author

tormi commented Dec 6, 2019

Seems like "php": ">=7.0.8", can be removed, it's defined in core now, vendor/drupal/core-composer-scaffold/composer.json:

  "require": {
    "composer-plugin-api": "^1.0.0",
    "php": ">=7.0.8"
  },

@tormi tormi force-pushed the feature/drupal-8.8 branch from cc2cc0a to ea7ec94 Compare December 6, 2019 09:31
@tormi tormi requested a review from floretan December 6, 2019 10:32
@tormi tormi requested a review from hkirsman December 6, 2019 10:56
@tormi
Copy link
Member Author

tormi commented Dec 6, 2019

@aleksijohansson
Copy link

aleksijohansson commented Dec 6, 2019

There is something wrong with the changes in this PR. I tested the master branch of this project locally and with that I can get to the Drupal installation page. Doing the same test with this branch ends up in this error:
Annotation 2019-12-06 202908
What I did was clone the repo, checkout this branch and run lando start.

@tormi
Copy link
Member Author

tormi commented Dec 7, 2019

@aleksijohansson, switching branches is not enough to rebuild the project if you have built it with pre-8.8 codebase first. I've added steps to test out to the issue description. Perform lando destroy -y, delete the project folder and then follow the testing steps mentioned above.

@tormi
Copy link
Member Author

tormi commented Dec 7, 2019

Your use case was more like How to upgrade my current D8.7 project to D8.8. Let's try to describe that process here as well, thanks for testing out!

@aleksijohansson
Copy link

@tormi I did not have anything pre-built, but instead started from scratch when testing this. I did exactly what you described now in the PR description for testing.

@tormi
Copy link
Member Author

tormi commented Dec 7, 2019

I tested the master branch of this project locally

What happened to this install? Did you happen to continue testing feature branch from there?

@aleksijohansson
Copy link

@tormi I tested that after I had first tested this branch.

@tormi
Copy link
Member Author

tormi commented Dec 7, 2019

Ok. Try this while you're on feature branch:

  1. rm -rf vendor
  2. rm composer.lock
  3. lando composer install

@aleksijohansson
Copy link

@tormi I tested again from scratch with:
image
and everything worked out fine. I was able to open the Drupal installation page and do an install without issues.

Copy link
Contributor

@floretan floretan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, thanks for keeping this project template up to date!

@tormi tormi merged commit 4eb33ae into master Dec 9, 2019
@tormi tormi deleted the feature/drupal-8.8 branch December 9, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants