Enhancement/8094 managing api failure#8113
Merged
Conversation
- Modified AdminPageSubscriber to include 'is_monthly' parameter in the button URL. - Enhanced rocketcdn.js to toggle visibility of pricing based on billing cycle selection. - Added a new function to update the button URL with the correct 'is_monthly' value based on the selected billing cycle.
…o enhancement/8094-managing-api-failure
jeawhanlee
approved these changes
Mar 2, 2026
wordpressfan
requested changes
Mar 4, 2026
Contributor
wordpressfan
left a comment
There was a problem hiding this comment.
Important point to be handled
…and saving it upon activation success
…to enhancement/8094-managing-api-failure
Base automatically changed from
feature/8018-plugin-ui-rocketcdn-one-click-purchase
to
develop
March 4, 2026 12:09
Contributor
|
@Miraeld plz fix conflicts and send it to QA |
- Introduced a new Tracking instance in NoticesSubscriber to track banner views. - Implemented track_rocketcdn_activation_failed_banner_viewed method in Tracking class. - Updated NoticesSubscriber to call the tracking method when the activation failed banner is viewed. - Modified the activation failed notice action link to include an ID for tracking. - Added event listener in rocketcdn.js to track clicks on the activation failed CTA. - Created trackRocketCDNActivationCTA function to handle Mixpanel tracking for CTA clicks.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes #8094
After completing the RocketCDN express checkout, users may encounter situations where the subscription activation fails. This PR adds two recovery mechanisms:
This prevents users from getting stuck with incomplete RocketCDN subscriptions after checkout.
Type of change
Detailed scenario
What was tested
Automated Testing:
Manual Testing:
is_active=falseandcdn_urlis emptyis_active=falsebutcdn_urlexistsHow to test
Needs API errors.
Affected Features & Quality Assurance Scope
Direct Impact:
QA Testing Scope:
Technical description
Documentation
Flow Diagram:
Implementation:
NoticesSubscriber::activation_failed_notice(): Displays admin notice when subscription is inactive without CDN URL. Reads express checkout URL from UserClient API.DataManagerSubscriber::maybe_retry_activation(): Fires onadmin_init, checks if subscription has CDN URL but is_active=false, then calls APIClient to retry activation via PATCH request.Both methods share subscription status checks via
APIClient::get_subscription_data()which reads fromrocketcdn_statustransient.Mandatory Checklist
Code validation
Code style
Unticked items justification
N/A - All items completed.
Additional Checks