Fix package name is retrieved from wrong branch. #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@gitlost We have a separate organization called I've sent an invite to you so you can create the test package you've referenced in this PR in that organization instead. |
schlessera
approved these changes
Jan 13, 2018
schlessera
added a commit
that referenced
this pull request
Jan 5, 2022
Fix package name is retrieved from wrong branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Adds version arg to
check_git_package_name()and passes to new functionget_raw_git_version()that returns what should be used in the raw github request (with limited accuracy - eg suffixes such as^0are just stripped).Needed to change an existing test to use the tag name
v0.1.0instead of the version0.1.0.