Use pretty name in list to cater for mixed-case names; add as optional field. #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
approved these changes
Nov 5, 2017
schlessera
pushed a commit
that referenced
this pull request
Jan 5, 2022
Use pretty name in list to cater for mixed-case names; add as optional field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #43
Uses
Composer\Package::getPrettyName()in matching installed package names as it's the same as the actualcomposer.jsonname, which can be case sensitive (though not usually), and adds it as an optional fieldpretty_nameto thelistandbrowsecommands.Also adds a test for the more usual case of having a lower-case only name in
composer.jsonwhere the git url is mixed-case, as originally reported in #43