Fix fatal error issue in in_array function

[itsmekopila]

Fix: #429

A fatal error occurred in the in_array function when the site options auto_update_plugins and auto_update_themes were set to string values. I fixed this by adding a condition to check if they are not arrays.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[swissspidy]

Would you be up for adding a test for this as well?

Please also update the branch by merging the latest changes from the main branch

[swissspidy]

Hmm now there are some changes from main in this diff 🤔 I was thinking more of a simple git merge main or git rebase main. But anyhow, some tests would be good. Let us know if you need help with that.

[swissspidy]

@itsmekopila friendly ping 👋 would you be able to address the diff issues and add some tests?

[itsmekopila]

@itsmekopila friendly ping 👋 would you be able to address the diff issues and add some tests?

I'm setting up WP-CLI tests locally to run tests and will fix diff issues.

[itsmekopila]

Hi @swissspidy,

Could you please guide me on how to set up the database and connect it properly to run Behat? I followed the WP CLI tests guide but ran into some issues. It seems like I wasn't able to connect the database correctly. When I run the composer run prepare-tests command, I get the error shown in the attached file. Also, when I run composer run behat, it just gets stuck and doesn’t load anything. I try with database type splite also.

Could you please guide me through the setup and testing process from the start?

Thanks in advance!

[swissspidy]

Since you're using MariaDB, I'd suggest running composer update again.

We just merged some MariaDB-related improvements on Friday to make running tests more robust. Then composer run prepare-tests should work better.

Using SQLite is a nice workaround though, then you don't need to run prepare-tests. But strange that it fails for you 🤔

[schlessera]

@itsmekopila Looking at the error you've posted, I can see that the script detected MySQL v10.4, which seems to be a bug in the script. I'll check to find out what is going on. I'm assuming you're using MariaDB v10.4.

[swissspidy]

@schlessera FYI we improved the db type detection quite a bit recently, see wp-cli/wp-cli-tests#246

[schlessera]

This is what I think is the problem here: wp-cli/wp-cli-tests#251

You have the mysql client binary installed and that makes the script think it is using MySQL, as it erroneously checks the client instead of the server.