Fix incorrect recurrence display for events with invalid schedules#99
Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom Aug 27, 2023
Conversation
johnbillion
approved these changes
Aug 25, 2023
danielbachhuber
approved these changes
Aug 27, 2023
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Great work on this, @MiguelAxcar ! Way to stick with it 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request is address issue reported in #52, where a cron event with invalid schedule was showing invalid information in the recurrence column.
Changes
Details
Cron_Event_Commandclass to check if schedule exists before formatting recurrence.Testing
The pull request include new test cases that cover described scenario, ensure that recurrence display is handled correct.
Impact
This fix make better reliability of
wp cron event listcommand, providing accurate informations about event recurrence.I kindly request review of these changes, and I'm available for any further discussion or adjustments as needed.
I would like to also thank @schlessera and @danielbachhuber for the support provided during 2023 WordCamp US Contributor Day.
Related wp-cli/wp-cli#5832