Skip to content

--due-now get events from wp_get_ready_cron_jobs() reviewed #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josedumas wants to merge 3 commits into from
Closed

--due-now get events from wp_get_ready_cron_jobs() reviewed #91

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f04cc25
When param --due-now get events from wp_get_ready_cron_jobs()
Dec 10, 2022
4160b70
Add check version because wp_get_ready_cron_jobs is since 5.1.0
Dec 10, 2022
d1794f7
Changes suggested by danielbachhuber
Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/Cron_Event_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,9 @@ public function run( $args, $assoc_args ) {
WP_CLI::error( 'Please specify one or more cron events, or use --due-now/--all.' );
}

$events = self::get_cron_events();
$is_due_now = Utils\get_flag_value( $assoc_args, 'due-now' );

$events = self::get_cron_events( $is_due_now );

if ( is_wp_error( $events ) ) {
WP_CLI::error( $events );
Expand Down Expand Up @@ -428,12 +430,18 @@ protected static function format_event( stdClass $event ) {
*
* @return array|WP_Error An array of event objects, or a WP_Error object if there are no events scheduled.
*/
protected static function get_cron_events() {
protected static function get_cron_events( $is_due_now = false ) {

// wp_get_ready_cron_jobs since 5.1.0
if ( $is_due_now && function_exists( 'wp_get_ready_cron_jobs' ) ) {
$crons = wp_get_ready_cron_jobs();
} else {
$crons = _get_cron_array();
}

$crons = _get_cron_array();
$events = array();

if ( empty( $crons ) ) {
if ( empty( $crons ) && ! $is_due_now ) {
return new WP_Error(
'no_events',
'You currently have no scheduled cron events.'
Expand Down