Skip to content

feat: addtl test#89

Merged
woutervanranst merged 1 commit into
masterfrom
fix-regression
May 12, 2026
Merged

feat: addtl test#89
woutervanranst merged 1 commit into
masterfrom
fix-regression

Conversation

@woutervanranst

@woutervanranst woutervanranst commented May 12, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Tests
    • Added test coverage to verify correct filtering behavior when listing blob storage paths, ensuring archived chunk variants are properly excluded from results.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cf442806-85a2-4bf3-964b-2d9fe27affc1

📥 Commits

Reviewing files that changed from the base of the PR and between 7e2bc27 and 14ae0c1.

📒 Files selected for processing (1)
  • src/Arius.AzureBlob.Tests/AzureBlobServiceTests.cs

📝 Walkthrough

Walkthrough

This PR adds a test case to verify that the blob listing service correctly filters out rehydrated chunk paths. When ListAsync is called with BlobPaths.ChunksPrefix, it should return only original chunks/... paths and exclude chunks-rehydrated/... matches.

Changes

Rehydrated chunk filtering validation

Layer / File(s) Summary
Rehydrated chunk exclusion test
src/Arius.AzureBlob.Tests/AzureBlobServiceTests.cs
New test ListAsync_ChunksPrefix_DoesNotReturnRehydratedChunkMatches sets up a fake container with both chunks/... and chunks-rehydrated/... blobs, calls ListAsync with the chunks prefix, and asserts only the original chunk path is returned.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'addtl test' is vague and does not clearly describe what test was added or its purpose. While it indicates a test was added, it lacks specificity about the actual change. Revise the title to be more descriptive, such as 'test: verify ListAsync excludes rehydrated chunks' or 'Add test for ListAsync with ChunksPrefix filtering'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-regression

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.77%. Comparing base (7e2bc27) to head (14ae0c1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   78.77%   78.77%           
=======================================
  Files          78       78           
  Lines        5277     5277           
  Branches      722      722           
=======================================
  Hits         4157     4157           
  Misses        929      929           
  Partials      191      191           
Flag Coverage Δ
linux 81.93% <ø> (ø)
windows 77.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@woutervanranst woutervanranst merged commit 73982a1 into master May 12, 2026
12 checks passed
@woutervanranst woutervanranst deleted the fix-regression branch June 8, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant