Speed up filetree archive staging#76
Closed
woutervanranst wants to merge 89 commits into
Closed
Conversation
…nranst/Arius7 into speedup-filetree-upload
…woutervanranst/Arius7 into speedup-filetree-upload" This reverts commit 353e702, reversing changes made to 46ab8fd.
Preserve leading and trailing spaces in filetree path segments while keeping canonical path validation for rooted paths, dot segments, repeated separators, and backslashes.
Owner
Author
|
@CodeRabbit please review |
Contributor
|
Tip For best results, initiate chat on the files or code changes.
[full_review] |
Owner
Author
|
Superseded by a replacement PR with ADR-aligned title and description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.stagingdirectory nodes, staging sessions/writers, and a staging-drivenFileTreeBuilderFileTreeService.EnsureStoredAsync, and remove obsolete manifest codeTest Plan
dotnet test --project \"src/Arius.Core.Tests/Arius.Core.Tests.csproj\"dotnet test --project \"src/Arius.Integration.Tests/Arius.Integration.Tests.csproj\" --treenode-filter \"/*/*/FileTreeBuilderIntegrationTests/*|/*/*/RoundtripTests/*\"slopwatch analyze --fail-on warningdotnet run --project \"src/Arius.Benchmarks/Arius.Benchmarks.csproj\" -c ReleaseBenchmark
Archive_Step_V1_Representative_Azurite: mean34.24 s, stddev0.292 s, allocated455.67 MBSummary by CodeRabbit
New Features
Documentation
Tests
Refactor