refactor: rename Ls* references to ListQuery* in tests and specs#48
Conversation
Rename internal code references from Ls-based naming to ListQuery-based naming across test files and specs, keeping the CLI layer (LsVerb, 'arius ls') unchanged since 'ls' is the user-facing command name. - Rename test files: LsHandlerTests → ListQueryHandlerTests, LsIntegrationTests → ListQueryIntegrationTests - Rename test classes and methods: LsCommandTests → ListQueryParsingTests, Ls_* → ListQuery_* - Rename spec directory: ls-command/ → list-query/ - Update spec references: LsCommand → ListQuery, LsOptions → ListQueryOptions - Fix namespace collision with using alias (ListQueryType) - All 295 tests pass (141 CLI + 154 Core)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe PR systematically renames Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 71.04% 71.04%
=======================================
Files 59 59
Lines 4687 4687
Branches 624 624
=======================================
Hits 3330 3330
Misses 1225 1225
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Ls*toListQuery*to align internal code naming with theListQuery/ListQueryHandlercore typesls-command/→list-query/and update all internal code references in specs (LsCommand→ListQuery,LsOptions→ListQueryOptions)LsVerb,arius lsverb, and all user-facinglsreferencesFiles changed
openspec/specs/ls-command/→openspec/specs/list-query/src/Arius.Core.Tests/Ls/LsHandlerTests.cs→ListQuery/ListQueryHandlerTests.cssrc/Arius.Integration.Tests/Pipeline/LsIntegrationTests.cs→ListQueryIntegrationTests.cssrc/Arius.Cli.Tests/CliTests.cs— method/property renamessrc/Arius.Cli.Tests/DependencyInjectionTests.cs— method renamesrc/Arius.Integration.Tests/Pipeline/PipelineFixture.cs— method renamesAll 295 tests pass (141 CLI + 154 Core).
Summary by CodeRabbit