Skip to content

External dependencies are not listed in package.json #610

Description

@kidroca

What react-native version are you using?
0.64.2

What react-native-pdf version are you using?
6.2.2

What platform does your issue occur on? (android/ios/both)
both

  1. Migrating to a newer version results in dependency errors - seen some other issue opened about it as well - regarding react-native-blob-util and fbjs.
    • It's not very obvious that the install process or dependencies changed
  2. Cleaning up package dependencies results in errors. For example removing fbjs
    • I've got nothing to remind me that it's used in another package so I thought it was a leftover

As per the install instructions: https://github.com/wonday/react-native-pdf#installation

# Using npm
npm install react-native-pdf react-native-blob-util fbjs --save

# or using yarn:
yarn add react-native-pdf react-native-blob-util fbjs

Since we need to install these package in order for react-native-pdf to function correctly, they are some kind of a dependency to react-native-pdf
Usually it's a peerDependency in order to be more compatible with a range of versions and prevent having 2 different versions of fbjs for example

Listing fbjs and react-native-blob-util as peerDependencies would fix both problems

Is there a reason these packages should not be listed as peerDependencies?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions