Conversation
| const cached = Interact.sequenceCache.get(cacheKey); | ||
| if (cached) return cached; | ||
|
|
||
| const sequence = getSequence(sequenceOptions, animationGroupArgs, context); |
Contributor
There was a problem hiding this comment.
using motion getSequence inside getSequence is confusing i would give it an alias.
packages/interact/src/core/add.ts
Outdated
| if (_isSequenceConfigRef(seqOrRef)) { | ||
| const resolved = instance.dataCache.sequences[seqOrRef.sequenceId]; | ||
|
|
||
| if (!resolved) return; |
Contributor
There was a problem hiding this comment.
i think silently failing here is hard for development i would add a console.warn for trying to reference an undefined sequence.
| const effectOptions = { | ||
| ...(effectId ? instance.dataCache.effects[effectId] || {} : {}), | ||
| ...effect, | ||
| }; |
Contributor
There was a problem hiding this comment.
for (const effect of seqEffects) {
const effectId = (effect as EffectRef).effectId;
const resolvedEffect = effectId
? instance.dataCache.effects[effectId] ?? {}
: {};
const effectOptions = { ...resolvedEffect, ...effect };
.
.
.
}
i feel this is more readable
# Conflicts: # .cursor/plans/sequence_docs_and_demos_9e654633.plan.md # packages/interact/src/core/Interact.ts # packages/interact/test/sequences.spec.ts # packages/motion/src/Sequence.ts # packages/motion/test/Sequence.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Screenshots / Demos
Additional Notes