Skip to content

fix: theme option padding [WPB-26141]#4991

Merged
MohamadJaara merged 1 commit into
developfrom
fix/theme-option-padding
Jun 24, 2026
Merged

fix: theme option padding [WPB-26141]#4991
MohamadJaara merged 1 commit into
developfrom
fix/theme-option-padding

Conversation

@Garzas

@Garzas Garzas commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-26141


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • fixed padding for theme options

@Garzas Garzas self-assigned this Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.92%. Comparing base (f83ed5a) to head (ba1ddec).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4991      +/-   ##
===========================================
- Coverage    48.93%   48.92%   -0.01%     
===========================================
  Files          646      646              
  Lines        23168    23172       +4     
  Branches      3552     3553       +1     
===========================================
  Hits         11337    11337              
- Misses       10779    10782       +3     
- Partials      1052     1053       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83ed5a...ba1ddec. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +181 to 184
HorizontalSpace.x12()
RadioButton(selected = isSelected, onClick = null)
HorizontalSpace.x8()
Text(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the fix that is needed adding HorizontalSpace will not fix it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohamadJaara why do you think that?
HorizontalSpace adds the missing paddings/spacings to the left and between RadioButton and Text label. The ticket is exactly about the broken left margin and RadioButtons being "glued" to the left side of the screen without proper left padding.

@Garzas Garzas requested a review from MohamadJaara June 24, 2026 11:07
@MohamadJaara MohamadJaara added this pull request to the merge queue Jun 24, 2026
Merged via the queue into develop with commit b36ff2d Jun 24, 2026
23 checks passed
@MohamadJaara MohamadJaara deleted the fix/theme-option-padding branch June 24, 2026 11:26
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants