-
-
Notifications
You must be signed in to change notification settings - Fork 233
[WIP] 1.2 Test Split - Modules own tests #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTowers
reviewed
Jun 21, 2022
LukeTowers
reviewed
Jun 21, 2022
LukeTowers
reviewed
Jun 21, 2022
Member
|
Hey guys, 2 thoughts on this -
|
LukeTowers
requested changes
Jun 21, 2022
Member
|
Member
As long as that doesn't create any conflicts, all good!
I suppose it will be handy to not have to instruct people to download or updates their test folders anymore. |
This modifies the plugin manager to internally treat plugin identifiers as lower case strings, only transforming them to their normalized versions when requested by methods like getPlugins() & getAllPlugins(). The idea behind this is that it provides a much simpler way to internally handle checking, especially for plugin replacement where casing could cause issues. Replaces #576. Fixes #575.
Member
Author
|
Removed global func/const imports in d1ff094 |
LukeTowers
approved these changes
Jun 22, 2022
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
PRs that implement a new feature or substantial change
maintenance
PRs that fix bugs, are translation changes or make only minor changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LukeTowers told me to...
This PR splits out tests into their related modules, allowing for each module to be targeted using the
winter:testcommand. Added to this is also proper namespacing and a bunch of minor bug fixes and tweaks.