Add automatic package registration and improved installation to Laravel Mix support#444
Add automatic package registration and improved installation to Laravel Mix support#444LukeTowers merged 9 commits intowip/snowboardfrom
Conversation
… so this it was unnecessary.
Also added additional checks to improve developer experience when running the commands.
|
@bennothommo with these changes all that's really needed from the package registration is the relative path to the Personally I'm thinking not, even if we wanted to expand our dependency checking logic in the future to look at related package.json files it would be better to autogenerate the path to those files instead of have separate config items for it since supporting them being set values in an array opens us up to the possibility that they could not match the mixJs path at some point in the future. |
Co-authored-by: Ben Thomson <git@alfreido.com>
|
@LukeTowers I started writing a PHP class to handle Would that be at all useful for this? Might be able to move some of that procedural code into this class. |
Co-authored-by: Ben Thomson <git@alfreido.com>
|
@bennothommo I was looking at that but I didn't really see the point to be honest. It felt a bit too much "enterprisey" without a clear reason for its existence or usefulness. Could you provide an example of how we could improve this code by using that class and / or what else that class could be used for? |
Refs: #440, #401.