Skip to content

Comments

Add automatic package registration and improved installation to Laravel Mix support#444

Merged
LukeTowers merged 9 commits intowip/snowboardfrom
wip/mix-changes
Feb 15, 2022
Merged

Add automatic package registration and improved installation to Laravel Mix support#444
LukeTowers merged 9 commits intowip/snowboardfrom
wip/mix-changes

Conversation

@LukeTowers
Copy link
Member

@LukeTowers LukeTowers commented Feb 10, 2022

Refs: #440, #401.

…ns, & themes.

Also renamed default to winter.mix.js instead of winter-mix.js started on the mix:install support.

Refs: #440, #401.
@LukeTowers LukeTowers added enhancement PRs that implement a new feature or substantial change Status: In Progress labels Feb 10, 2022
@LukeTowers LukeTowers added this to the v1.1.8 milestone Feb 10, 2022
@LukeTowers LukeTowers changed the base branch from wip/snowboard-workspaces to wip/snowboard February 11, 2022 20:25
LukeTowers and others added 3 commits February 11, 2022 14:42
@LukeTowers
Copy link
Member Author

@bennothommo with these changes all that's really needed from the package registration is the relative path to the winter.mix.js file from the base path. Do you see any value in continuing to have an array of values (path, package.json, winter.mix.js) tied to the package name instead of just the one relative path?

Personally I'm thinking not, even if we wanted to expand our dependency checking logic in the future to look at related package.json files it would be better to autogenerate the path to those files instead of have separate config items for it since supporting them being set values in an array opens us up to the possibility that they could not match the mixJs path at some point in the future.

Co-authored-by: Ben Thomson <git@alfreido.com>
@bennothommo
Copy link
Member

@LukeTowers I started writing a PHP class to handle package.json manipulation for my wip/snowboard-workspaces branch here: e33fa94

Would that be at all useful for this? Might be able to move some of that procedural code into this class.

Co-authored-by: Ben Thomson <git@alfreido.com>
@LukeTowers
Copy link
Member Author

@bennothommo I was looking at that but I didn't really see the point to be honest. It felt a bit too much "enterprisey" without a clear reason for its existence or usefulness. Could you provide an example of how we could improve this code by using that class and / or what else that class could be used for?

@LukeTowers LukeTowers changed the title [WIP] Add automatic package registration and improved installation to Laravel Mix support Add automatic package registration and improved installation to Laravel Mix support Feb 15, 2022
@LukeTowers LukeTowers merged commit 5ead84c into wip/snowboard Feb 15, 2022
@LukeTowers LukeTowers deleted the wip/mix-changes branch February 15, 2022 08:46
@LukeTowers LukeTowers mentioned this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that implement a new feature or substantial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants