Skip to content

Conversation

@jaxwilko
Copy link
Member

@jaxwilko jaxwilko commented Jan 31, 2022

This PR adds some of the Laravel defaults into Winter's configs.

app.asset_url was added with reference to this PR which adds support for Laravel asset urls.

IMHO we should consider env() calls for every config that Laravel uses them for, which will be possible once #404 is merged. @bennothommo @LukeTowers thoughts?

@LukeTowers LukeTowers added this to the v1.1.8 milestone Jan 31, 2022
@LukeTowers LukeTowers added Status: In Progress maintenance PRs that fix bugs, are translation changes or make only minor changes labels Jan 31, 2022
@LukeTowers LukeTowers changed the title [WIP] Config Update Add support for the Laravel asset() helpers Jan 31, 2022
@bennothommo
Copy link
Member

IMHO we should consider env() calls for every config that Laravel uses them for

I cannot "yes" this enough.

@LukeTowers
Copy link
Member

IMHO we should consider env() calls for every config that Laravel uses them for

I agree with that and once #404 is merged then the main blocker to that in the past will be able to be dealt with and we can have a configuration system that works well for newbies and pros. I'm excited for it :)

@LukeTowers LukeTowers merged commit 9cb42fc into develop Feb 13, 2022
@LukeTowers LukeTowers deleted the config-update branch February 13, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants