-
-
Notifications
You must be signed in to change notification settings - Fork 33
Restore Laravel 6 behavior to public visibility for local driver #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@driesvints if you have a moment do you recall or have a link to the reasoning behind changing the default from public to private for the local Flysystem driver in Laravel 9? |
|
@LukeTowers that got changed in Flysystem v3 so you'll have to ask them. Afaik it's a more safe and sensible default. You should always use the same user to handle files. |
|
@driesvints I agree in theory that it's more safe default, the PHP user can access the files but the problem comes when the webserver user wants to fetch them to respond to requests, which is the default used by a few providers, ServerPilot & Cleavr for example. Any recommendations for how to handle that use case? |
|
Not really sorry.. |
|
Thanks anyways :) |
Fixes wintercms/winter#503
@LukeTowers @bennothommo @jaxwilko
Here's my preferred solution to this.