Skip to content

Improve ClassLoader support on Windows #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukeTowers merged 1 commit into from
Dec 20, 2022
Merged

Improve ClassLoader support on Windows #136

LukeTowers merged 1 commit into from
Dec 20, 2022
+1 −1

Conversation

@damsfx
Copy link
Contributor

@damsfx damsfx commented Dec 20, 2022

On windows the basePath does not necessarily start with a slash or backslash.

See : #72 (comment)

@damsfx
Bugfix paths on Windows.
a559dfe 
On windows the basePath does not necessarily start with a slash or backslash.

See : wintercms#72 (comment)
@what-the-diff
Copy link

what-the-diff bot commented Dec 20, 2022

  • The function resolvePath() was changed to include the base path in its check for a valid file.

@LukeTowers LukeTowers changed the title Bugfix paths on Windows. Improve ClassLoader support on Windows Dec 20, 2022
@LukeTowers LukeTowers merged commit ac3be74 into wintercms:develop Dec 20, 2022
@LukeTowers LukeTowers added this to the v1.2.2 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@damsfx @LukeTowers