Define string cursors to be code unit offsets#16
Merged
Merged
Conversation
Change the specification to define a cursor value as being a code unit offset. Note that the meaning of "code unit" depends on how the host represents strings; for UTF-8 it's a byte, for UTF-16 a value in [0,0xFFFF], and for UTF-32 it's a whole codepoint. Three fundamental reasons to make this change: - eliminate differences in behavior between different web browsers - allow hosts to reason about string offsets - define a meaning for cursor values for UTF-8 hosts Fixes #11.
Owner
Author
|
wdyt @jakobkummerow ? |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the specification to define a cursor value as being a code unit offset. Note that the meaning of "code unit" depends on how the host represents strings; for UTF-8 it's a byte, for UTF-16 a value in [0,0xFFFF], and for UTF-32 it's a whole codepoint.
Three fundamental reasons to make this change:
Fixes #11.