Landlock causes HTTPs permission issues#213
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
When building a docker image from the latest main branch, a permission error occurs when providing the main HTTPs certificate and private key via the config file. This is due to the fact that on linux machines, landlock rules are applied before the HTTP server loads the necessary files, which are not included in the rule list. This can be reporduced by creating a linux docker image, enabiling the HTTP proxy, and providing
CertFileandKeyFilevia the config file.This fix adds the files to the rulelist, allowing the HTTP server to correctly load them. An alternative approach would be to load the files into the HTTP server before preforming the lock, but I wanted to keep the current order in case there is something I am missing.
This fix enables the correct behavior on my end. Please let me know if there any any issues, I would be happy to fix them.
Thanks!