Conversation
uvchik
reviewed
Dec 9, 2019
windpowerlib/wind_farm.py
Outdated
| "If you use `wake_losses_model` '{model}' your WindFarm " | ||
| "needs an efficiency but `efficiency` of {farm} is {eff}.") | ||
| raise ValueError(msg.format(model=wake_losses_model, farm=self, | ||
| eff=self.efficiency)) |
Member
There was a problem hiding this comment.
The output of farm is quite long and people may miss the rest of the message. Is it possible to change the order?
Something like this:
- "If you use `wake_losses_model` '{model}' your WindFarm "
- "needs an efficiency but `efficiency` of {farm} is {eff}.")
+ "If you use `wake_losses_model` '{model}' your WindFarm "
+ "needs an efficiency but `efficiency` is {eff}.\n\n"
+ "Failing farm:\n {farm}")
uvchik
approved these changes
Jan 7, 2020
Member
Author
|
I found another one of these messages.. nice to have when there is time: check for all messages. |
Member
|
There was a merge conflict due to the stickler-PR I just merged but I fixed it. Sorry 😄 |
Member
I would not fix it here but rather open a new issue and merge this. |
uvchik
approved these changes
Jan 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #69.