Add optional read length/overrun parameter on Values#86
Merged
williballenthin merged 2 commits intowilliballenthin:masterfrom Dec 30, 2018
Merged
Add optional read length/overrun parameter on Values#86williballenthin merged 2 commits intowilliballenthin:masterfrom
williballenthin merged 2 commits intowilliballenthin:masterfrom
Conversation
williballenthin
requested changes
Dec 29, 2018
Owner
williballenthin
left a comment
There was a problem hiding this comment.
i like the idea of this PR. it does seem to provide forensic value without making the code much more complex. looking forward to hearing about what you discover!
i've made some minor requests about code style, otherwise, good to go!
Contributor
Author
|
I've already had success using this technique. A client system was found to have a backdoor: C:\Windows\cfmon.bat and the slack space contained evidence of a second, previous backdoor: C:\Windows\cmdacobin\RE[B]ell.bat |
williballenthin
approved these changes
Dec 30, 2018
| return decode_utf16le(d) | ||
| if overrun > 0: | ||
| # decode_utf16le() only returns the first string, but if we explicitly | ||
| # ask for overrun, let's make a best-effort to decode as much as possible. |
Owner
There was a problem hiding this comment.
excellent explanation, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optional parameter allows reading back arbitrary length data from a Value, including overrunning the current data length. This is useful for forensic analysis applications that may wish to examine overwritten key data. Values are non-truncating, thus will preserve old data in the slack space if overwritten by a smaller length value.