Skip to content

GSoD Project PR review workflow #1045

@lijiarui

Description

@lijiarui

hi GSoD tech writers!

Thanks for contributing so much to Wechaty Community, you all create so much fantastic PR. And thanks for @proudofsimin @Rohitesh-Kumar-Jain coordination.

I received @proudofsimin feedback, and I suggest the volunteer team can file an issue like this: #1026 and assign this issue to me to track the high priority PR. I would fill in the blank to synchronize PR review progress. And I suggest our GSoD team follow our PR reviewing and approving rules as follows:

PR Reviewing & Approving Workflow:

For writers:

Writers who are in the same team are REQUIRED to review each other’s PR, and give “Request changes” or “Approve”
Writers are encouraged to give “Request changes”, “Approve”, or “Comment” to any PRs. (please contribute to the whole team by doing it!)

For volunteers:

Volunteers are REQUIRED to review all PRs created by writers and give “Request changes” or “Approve”

Mentors are in charge of reviewing the PR after:

  • Volunteers create an issue list about the high priority PR
  • PR passed all the CI tests (CLA & unit testings)
  • PR gets approved by all the project team members (if applicable, 0-1 approval)
  • PR gets approved by all volunteers (2 approvals)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions