fix(mcp): bound image uploads and expose bridge diagnostics#210
Open
lizhong1989 wants to merge 1 commit into
Open
fix(mcp): bound image uploads and expose bridge diagnostics#210lizhong1989 wants to merge 1 commit into
lizhong1989 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uploadImageanduploadImage:completerequests to a dedicated 60-second timeout/statusWECHATSYNC_UPLOAD_TIMEOUTWhy
A platform adapter can leave
uploadImage(blob)pending indefinitely. The CLI processes local images sequentially, so one stuck upload blocked the entire sync until the bridge-wide six-minute timeout.Separately, when an old Primary process still owned ports 9527/9528 but the extension was disconnected, new CLI instances could only report a generic connection error. Exposing process diagnostics makes the stale owner identifiable without introducing unsafe automatic process termination.
Closes #208.
Partially addresses #207. A safe reset/takeover mechanism still needs an ownership or heartbeat design.
Tests
corepack yarn workspace @wechatsync/mcp-server buildcorepack yarn workspace @wechatsync/cli buildcorepack yarn workspace @wechatsync/mcp-server testAdded coverage for:
All 3 tests pass on Windows 11 / Node.js 24.14.0.
Compatibility
syncArticlekeeps the existing six-minute timeout./statusfields remain unchanged; new fields are additive.WECHATSYNC_UPLOAD_TIMEOUT.