test(e2e): make browser close before tests run#2018
Merged
alexander-akait merged 1 commit intowebpack:masterfrom Jun 13, 2019
Merged
test(e2e): make browser close before tests run#2018alexander-akait merged 1 commit intowebpack:masterfrom
alexander-akait merged 1 commit intowebpack:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 29 29
Lines 1149 1149
Branches 327 327
=======================================
Hits 1066 1066
Misses 79 79
Partials 4 4Continue to review full report at Codecov.
|
6 tasks
hiroppy
approved these changes
Jun 11, 2019
wizardofhogwarts
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Jest seems to have problems with the browser taking a while to close after a test has failed. Running tests after the browser has closed seems to be a workaround. I believe this will fix hanging on Windows CI.
Breaking Changes
None
Additional Info