docs(contributing): adds prebuild instructions#757
Merged
evenstensberg merged 4 commits intowebpack:masterfrom Mar 8, 2019
Merged
docs(contributing): adds prebuild instructions#757evenstensberg merged 4 commits intowebpack:masterfrom
evenstensberg merged 4 commits intowebpack:masterfrom
Conversation
Member
|
Wow thanks a bunch for this! I was looking for this myself earlier and didn't even realize it wasn't in CONTRIBUTING.md |
Contributor
Author
|
Happy to help! |
ematipico
approved these changes
Feb 27, 2019
dhruvdutt
approved these changes
Feb 27, 2019
Contributor
|
@misterdev Can you please sign the CLA? 😅 |
|
You mean @misterdev |
Contributor
Author
|
I see it is already signed :) Anyway I've renewed my signature |
|
@misterdev Thanks for your update. I labeled the Pull Request so reviewers will review it again. @dhruvdutt Please review the new changes. |
Contributor
Author
|
I've indented those instructions to make them even with #768 |
evenstensberg
approved these changes
Mar 3, 2019
Member
evenstensberg
left a comment
There was a problem hiding this comment.
lgtm, thanks for the fix
Member
|
We're currently freezing PR's until our tests are fixed, sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds few lines to
CONTRIBUTING.mdabout the undocumentedboostrapnpm script that should be run to set up the project