Skip to content

Fix stylelint formatter path #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaKXz merged 1 commit into from
Dec 18, 2016
Merged

Fix stylelint formatter path #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ See [stylelint options](http://stylelint.io/user-guide/node-api/#options), for t
* `context`: String indicating the root of your SCSS files. Default inherits from webpack config.
* `files`: Change the glob pattern for finding files. Default: (`['**/*.s?(a|c)ss']`)
* `syntax`: Use `'scss'` to lint .scss files. Default (`undefined`)
* `formatter`: Use a custom formatter to print errors to the console. Default: (`require('stylelint/dist/formatters/stringFormatter').default`)
* `formatter`: Use a custom formatter to print errors to the console. Default: (`require('stylelint/lib/formatters/stringFormatter').default`)
* `failOnError`: Have Webpack's build process die on error. Default: `false`
* `quiet`: Don't print stylelint output to the console. Default: `false`

Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
var path = require('path');
var arrify = require('arrify');
var assign = require('object-assign');
var formatter = require('stylelint/dist/formatters/stringFormatter').default;
var formatter = require('stylelint/lib/formatters/stringFormatter');
Copy link
Copy Markdown

@jeddy3 jeddy3 Dec 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend you use the public API here rather than an undocumented path:

var formatter = require('stylelint').formatters.string;

It'll save you from having to make changes like this in the future.


// Modules
var runCompilation = require('./lib/run-compilation');
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
},
"homepage": "https://github.com/vieron/stylelint-webpack-plugin#readme",
"peerDependencies": {
"stylelint": "^7.0.1"
"stylelint": "^7.7.0"
},
"dependencies": {
"arrify": "^1.0.1",
"chalk": "^1.1.3",
"object-assign": "^4.1.0",
"stylelint": "^7.3.1",
"stylelint": "^7.7.0",
"webpack": "^1.13.2"
},
"devDependencies": {
Expand Down
75 changes: 35 additions & 40 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ camelcase@^1.0.2:
version "1.2.1"
resolved "https://registry.yarnpkg.com/camelcase/-/camelcase-1.2.1.tgz#9bb5304d2e0b56698b2c758b08a3eaa9daa58a39"

camelcase@^2.0.0, camelcase@^2.0.1, camelcase@^2.1.0:
camelcase@^2.0.0, camelcase@^2.1.0:
version "2.1.1"
resolved "https://registry.yarnpkg.com/camelcase/-/camelcase-2.1.1.tgz#7c1d16d679a1bbe59ca02cacecfb011e201f5a1f"

Expand Down Expand Up @@ -517,7 +517,7 @@ cliui@^2.1.0:
right-align "^0.1.1"
wordwrap "0.0.2"

cliui@^3.0.3, cliui@^3.2.0:
cliui@^3.2.0:
version "3.2.0"
resolved "https://registry.yarnpkg.com/cliui/-/cliui-3.2.0.tgz#120601537a916d29940f934da3b48d585a39213d"
dependencies:
Expand Down Expand Up @@ -641,7 +641,7 @@ core-util-is@~1.0.0:
version "1.0.2"
resolved "https://registry.yarnpkg.com/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7"

cosmiconfig@^2.0.0:
cosmiconfig@^2.1.1:
version "2.1.1"
resolved "https://registry.yarnpkg.com/cosmiconfig/-/cosmiconfig-2.1.1.tgz#817f2c2039347a1e9bf7d090c0923e53f749ca82"
dependencies:
Expand Down Expand Up @@ -1939,9 +1939,9 @@ kind-of@^3.0.2:
dependencies:
is-buffer "^1.0.2"

known-css-properties@^0.0.5:
version "0.0.5"
resolved "https://registry.yarnpkg.com/known-css-properties/-/known-css-properties-0.0.5.tgz#33de5b8279010a72db917d33119e4c27c078490a"
known-css-properties@^0.0.6:
version "0.0.6"
resolved "https://registry.yarnpkg.com/known-css-properties/-/known-css-properties-0.0.6.tgz#71a0b8fde1b6e3431c471efbc3d9733faebbcfbf"

latest-version@^2.0.0:
version "2.0.0"
Expand Down Expand Up @@ -2597,9 +2597,9 @@ postcss-reporter@^1.2.1, postcss-reporter@^1.3.3:
log-symbols "^1.0.2"
postcss "^5.0.0"

postcss-reporter@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/postcss-reporter/-/postcss-reporter-2.0.0.tgz#d25e74ba7fce911e2aa72ec1ae592fade6ec3671"
postcss-reporter@^3.0.0:
version "3.0.0"
resolved "https://registry.yarnpkg.com/postcss-reporter/-/postcss-reporter-3.0.0.tgz#09ea0f37a444c5693878606e09b018ebeff7cf8f"
dependencies:
chalk "^1.0.0"
lodash "^4.1.0"
Expand Down Expand Up @@ -3191,23 +3191,23 @@ stylehacks@^2.3.0:
text-table "^0.2.0"
write-file-stdout "0.0.2"

stylelint@^7.3.1:
version "7.6.0"
resolved "https://registry.yarnpkg.com/stylelint/-/stylelint-7.6.0.tgz#ddeb06ccc95f72c119fcde5e85439fb7e9cde4df"
stylelint@^7.7.0:
version "7.7.0"
resolved "https://registry.yarnpkg.com/stylelint/-/stylelint-7.7.0.tgz#bf222c2a202c0b02d7834ad321fe0883d33cfde0"
dependencies:
autoprefixer "^6.0.0"
balanced-match "^0.4.0"
chalk "^1.1.1"
colorguard "^1.2.0"
cosmiconfig "^2.0.0"
cosmiconfig "^2.1.1"
doiuse "^2.4.1"
execall "^1.0.0"
get-stdin "^5.0.0"
globby "^6.0.0"
globjoin "^0.1.4"
html-tags "^1.1.1"
ignore "^3.2.0"
known-css-properties "^0.0.5"
known-css-properties "^0.0.6"
lodash "^4.0.0"
log-symbols "^1.0.2"
meow "^3.3.0"
Expand All @@ -3216,7 +3216,7 @@ stylelint@^7.3.1:
postcss "^5.0.20"
postcss-less "^0.14.0"
postcss-media-query-parser "^0.2.0"
postcss-reporter "^2.0.0"
postcss-reporter "^3.0.0"
postcss-resolve-nested-selector "^0.1.1"
postcss-scss "^0.4.0"
postcss-selector-parser "^2.1.1"
Expand All @@ -3228,7 +3228,7 @@ stylelint@^7.3.1:
stylehacks "^2.3.0"
sugarss "^0.2.0"
svg-tags "^1.0.0"
table "^3.7.8"
table "^4.0.1"

sugarss@^0.2.0:
version "0.2.0"
Expand Down Expand Up @@ -3275,6 +3275,17 @@ table@^3.7.8:
slice-ansi "0.0.4"
string-width "^2.0.0"

table@^4.0.1:
version "4.0.1"
resolved "https://registry.yarnpkg.com/table/-/table-4.0.1.tgz#a8116c133fac2c61f4a420ab6cdf5c4d61f0e435"
dependencies:
ajv "^4.7.0"
ajv-keywords "^1.0.0"
chalk "^1.1.1"
lodash "^4.0.0"
slice-ansi "0.0.4"
string-width "^2.0.0"

tapable@^0.1.8, tapable@~0.1.8:
version "0.1.10"
resolved "https://registry.yarnpkg.com/tapable/-/tapable-0.1.10.tgz#29c35707c2b70e50d07482b5d202e8ed446dafd4"
Expand Down Expand Up @@ -3546,10 +3557,6 @@ window-size@0.1.0:
version "0.1.0"
resolved "https://registry.yarnpkg.com/window-size/-/window-size-0.1.0.tgz#5438cd2ea93b202efa3a19fe8887aee7c94f9c9d"

window-size@^0.1.4:
version "0.1.4"
resolved "https://registry.yarnpkg.com/window-size/-/window-size-0.1.4.tgz#f8e1aa1ee5a53ec5bf151ffa09742a6ad7697876"

window-size@^0.2.0:
version "0.2.0"
resolved "https://registry.yarnpkg.com/window-size/-/window-size-0.2.0.tgz#b4315bb4214a3d7058ebeee892e13fa24d98b075"
Expand Down Expand Up @@ -3667,7 +3674,7 @@ xo@^0.16.0:
version "4.0.1"
resolved "https://registry.yarnpkg.com/xtend/-/xtend-4.0.1.tgz#a5c6d532be656e23db820efb943a1f04998d63af"

y18n@^3.2.0, y18n@^3.2.1:
y18n@^3.2.1:
version "3.2.1"
resolved "https://registry.yarnpkg.com/y18n/-/y18n-3.2.1.tgz#6d15fba884c08679c0d77e88e7759e811e07fa41"

Expand All @@ -3685,17 +3692,14 @@ yargs@^1.2.6:
version "1.3.3"
resolved "https://registry.yarnpkg.com/yargs/-/yargs-1.3.3.tgz#054de8b61f22eefdb7207059eaef9d6b83fb931a"

yargs@^3.5.4:
version "3.32.0"
resolved "https://registry.yarnpkg.com/yargs/-/yargs-3.32.0.tgz#03088e9ebf9e756b69751611d2a5ef591482c995"
yargs@^3.5.4, yargs@~3.10.0:
version "3.10.0"
resolved "https://registry.yarnpkg.com/yargs/-/yargs-3.10.0.tgz#f7ee7bd857dd7c1d2d38c0e74efbd681d1431fd1"
dependencies:
camelcase "^2.0.1"
cliui "^3.0.3"
decamelize "^1.1.1"
os-locale "^1.4.0"
string-width "^1.0.1"
window-size "^0.1.4"
y18n "^3.2.0"
camelcase "^1.0.2"
cliui "^2.1.0"
decamelize "^1.0.0"
window-size "0.1.0"

yargs@^6.0.0:
version "6.5.0"
Expand All @@ -3715,12 +3719,3 @@ yargs@^6.0.0:
window-size "^0.2.0"
y18n "^3.2.1"
yargs-parser "^4.2.0"

yargs@~3.10.0:
version "3.10.0"
resolved "https://registry.yarnpkg.com/yargs/-/yargs-3.10.0.tgz#f7ee7bd857dd7c1d2d38c0e74efbd681d1431fd1"
dependencies:
camelcase "^1.0.2"
cliui "^2.1.0"
decamelize "^1.0.0"
window-size "0.1.0"