Rename pool2d MLRoundingType - Simplify the operand layout support of conv2d and pooling 2d operations by fdwr · Pull Request #770 · webmachinelearning/webnn

fdwr · 2024-10-23T23:50:58Z

Fixes #324

Rather than having two output shape parameters, an explicit output size and an output rounding mode, be more explicit in WebNN such that the caller passes the explicit output shape, resolving any higher-level policy beforehand (like with convTranspose2d):

dictionary MLPool2dOptions : MLOperatorOptions {
  sequence<[EnforceRange] unsigned long> windowDimensions;
  sequence<[EnforceRange] unsigned long> padding;
  sequence<[EnforceRange] unsigned long> strides;
  sequence<[EnforceRange] unsigned long> dilations;
  MLInputOperandLayout layout = "nchw";
- MLRoundingType roundingType = "floor";
  sequence<[EnforceRange] unsigned long> outputSizes;
};

Additional changes:

Added spec:infra; type:dfn; text:string due to new build failures unrelated to my change (thanks Dominique).
Rewrapped instanceNormalization for linter error.
Update linter to display line numbers (save valuable time diagnosing errors) and display success message (rather than confusing silence).

Preview | Diff

jlewis-austin · 2024-12-10T17:10:45Z

    1. If any value in |options|.{{MLPool2dOptions/dilations}} is not greater than 0, then [=exception/throw=] a {{TypeError}}.
    1. Let |desc| be a copy of |input|.{{MLOperand/[[descriptor]]}}.
-    1. Let |outputShape| be the result of [=MLGraphBuilder/calculating pool2d output sizes=] given |options|.{{MLPool2dOptions/layout}}, |input|'s [=MLOperand/shape=], |options|.{{MLPool2dOptions/roundingType}}, |options|.{{MLPool2dOptions/windowDimensions}}, |options|.{{MLPool2dOptions/padding}}, |options|.{{MLPool2dOptions/strides}}, |options|.{{MLPool2dOptions/dilations}}, and |options|.{{MLPool2dOptions/outputSizes}} (if it [=map/exists=]).
+    1. Let |outputShape| be the result of [=MLGraphBuilder/calculating pool2d output sizes=] given |options|.{{MLPool2dOptions/layout}}, |input|'s [=MLOperand/shape=], |options|.{{MLPool2dOptions/windowDimensions}}, |options|.{{MLPool2dOptions/padding}}, |options|.{{MLPool2dOptions/strides}}, |options|.{{MLPool2dOptions/dilations}}, and |options|.{{MLPool2dOptions/outputSizes}} (if it [=map/exists=]).


The outputSizes validation above in 13.2 doesn't appear to be correct--shouldn't it be similar to this logic?

I think this is now resolved by Joshua?

inexorabletash · 2025-02-25T18:27:34Z

This implicitly resolves #374 as well, doesn't it?

inexorabletash · 2025-02-25T19:49:25Z

This PR needs a redo since there's been a lot of spec churn since Nov 2024. But one thing I noticed in the current spec text:

If options.outputSizes exists, or if options.padding does not exist, set options.padding to the list « 0, 0, 0, 0 ».

That implies that if outputSizes becomes a required option, then any passed padding will always be ignored. Flaw in the current text? I think the first clause "if options.outputSizes exists" is bogus today, and should be removed.

fdwr · 2025-07-18T00:14:54Z

I'm confused by the build errors, as I didn't touch any of those lines, and [=string=] seems unrelated 🙃:

      LINE 1713:36: Multiple possible 'string' dfn refs.
      Arbitrarily chose https://infra.spec.whatwg.org/#string
      To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
      spec:infra; type:dfn; text:string
      spec:rdf12-concepts; type:dfn; text:string
      [=string=]

dontcallmedom · 2025-07-18T06:53:16Z

the build error is indeed unrelated to the particular change, but linked to the definition set bikeshed uses for auto-linking.

the simplest short term solution is to add spec:infra; type:dfn; text:string in the existing <pre class="link-defaults"> on L50.

fdwr · 2025-09-11T03:47:23Z

MLPool2dOptions::outputShapeRounding.

SGTM

@huningxin: Any changes desired?

huningxin · 2025-09-23T05:47:54Z

        1. If |options|.{{MLPool2dOptions/outputSizes}} [=map/exists=], then:
-        1. Let « |outputHeight|, |outputWidth| » be |options|.{{MLPool2dOptions/outputSizes}}.
+            1. Let « |outputHeight|, |outputWidth| » be |options|.{{MLPool2dOptions/outputSizes}}.
        1. If neither |outputHeight| equals floor( |calculatedOutputHeight| ) and |outputWidth| equals floor( |calculatedOutputWidth| ), nor |outputHeight| equals ceil( |calculatedOutputHeight| ) and |outputWidth| equals ceil( |calculatedOutputWidth| ), then [=exception/throw=] a {{TypeError}}.


And this line should also indent.

True. I was thinking it would just fall through safely, but it's unnecessary to check this condition because we already know that calculating conv2d output sizes computing legal sizes.

huningxin

LGTM, thanks @fdwr !

… conv2d and pooling 2d operations (#770) SHA: a3e8163 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This CL renames MLPool2dOptions::roundingType to MLPool2dOptions::outputShapeRounding in test files and implementations according to Spec change [1]. [1] webmachinelearning/webnn#770 Bug: 498118207 Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel

This CL renames MLPool2dOptions::roundingType to MLPool2dOptions::outputShapeRounding in test files and implementations according to Spec change [1]. [1] webmachinelearning/webnn#770 Bug: 498118207 Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel

This CL renames MLPool2dOptions::roundingType to MLPool2dOptions::outputShapeRounding in test files and implementations according to Spec change [1]. [1] webmachinelearning/webnn#770 Bug: 498118207 Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Auto-Submit: Dai, Feng <feng.dai@intel.com> Commit-Queue: Dai, Feng <feng.dai@intel.com> Cr-Commit-Position: refs/heads/main@{#1618021}

…ops" This reverts commit e581146. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6349833846652928 Sample build with failed test: https://ci.chromium.org/b/8683829578450763649 Affected test(s): [://\:blink_wpt_tests!webtest::virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests#averagePool2d.https.any.html?cpu](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_wpt_tests%21webtest::virtual%2Fwebnn-service-on-cpu%2Fexternal%2Fwpt%2Fwebnn%2Fconformance_tests%23averagePool2d.https.any.html%3Fcpu?q=VHash%3A2dc5f607fec8a763) [://\:blink_wpt_tests!webtest::virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests#maxPool2d.https.any.html?cpu](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_wpt_tests%21webtest::virtual%2Fwebnn-service-on-cpu%2Fexternal%2Fwpt%2Fwebnn%2Fconformance_tests%23maxPool2d.https.any.html%3Fcpu?q=VHash%3A2dc5f607fec8a763) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6349833846652928&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7717139&type=BUG Original change's description: > webnn: rename roundingType to outputShapeRounding for pool2d ops > > This CL renames MLPool2dOptions::roundingType to > MLPool2dOptions::outputShapeRounding in test files and implementations > according to Spec change [1]. > > [1] webmachinelearning/webnn#770 > > Bug: 498118207 > Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 > Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 > Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Auto-Submit: Dai, Feng <feng.dai@intel.com> > Commit-Queue: Dai, Feng <feng.dai@intel.com> > Cr-Commit-Position: refs/heads/main@{#1618021} > Bug: 498118207 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I492d6269e88cfb4b65a22f495a2b73a1168c7747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7783895 Reviewed-by: Alex Gough <ajgo@chromium.org> Owners-Override: Adem Derinel <derinel@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Adem Derinel <derinel@google.com> Reviewed-by: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1618876}

…ops" This reverts commit e5811467122a07253805711cf7331c2de1741f1d. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6349833846652928 Sample build with failed test: https://ci.chromium.org/b/8683829578450763649 Affected test(s): [://\:blink_wpt_tests!webtest::virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests#averagePool2d.https.any.html?cpu](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_wpt_tests%21webtest::virtual%2Fwebnn-service-on-cpu%2Fexternal%2Fwpt%2Fwebnn%2Fconformance_tests%23averagePool2d.https.any.html%3Fcpu?q=VHash%3A2dc5f607fec8a763) [://\:blink_wpt_tests!webtest::virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests#maxPool2d.https.any.html?cpu](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_wpt_tests%21webtest::virtual%2Fwebnn-service-on-cpu%2Fexternal%2Fwpt%2Fwebnn%2Fconformance_tests%23maxPool2d.https.any.html%3Fcpu?q=VHash%3A2dc5f607fec8a763) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6349833846652928&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7717139&type=BUG Original change's description: > webnn: rename roundingType to outputShapeRounding for pool2d ops > > This CL renames MLPool2dOptions::roundingType to > MLPool2dOptions::outputShapeRounding in test files and implementations > according to Spec change [1]. > > [1] webmachinelearning/webnn#770 > > Bug: 498118207 > Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 > Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 > Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Auto-Submit: Dai, Feng <feng.dai@intel.com> > Commit-Queue: Dai, Feng <feng.dai@intel.com> > Cr-Commit-Position: refs/heads/main@{#1618021} > Bug: 498118207 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I492d6269e88cfb4b65a22f495a2b73a1168c7747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7783895 Reviewed-by: Alex Gough <ajgo@chromium.org> Owners-Override: Adem Derinel <derinel@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Adem Derinel <derinel@google.com> Reviewed-by: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1618876}

…eRounding for pool2d ops, a=testonly Automatic update from web-platform-tests webnn: rename roundingType to outputShapeRounding for pool2d ops This CL renames MLPool2dOptions::roundingType to MLPool2dOptions::outputShapeRounding in test files and implementations according to Spec change [1]. [1] webmachinelearning/webnn#770 Bug: 498118207 Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Auto-Submit: Dai, Feng <feng.dai@intel.com> Commit-Queue: Dai, Feng <feng.dai@intel.com> Cr-Commit-Position: refs/heads/main@{#1618021} -- wpt-commits: 1654471ad9b5ff35861d80d3d40cce113c6acb9d wpt-pr: 59145

…tputShapeRounding for pool2d ops", a=testonly Automatic update from web-platform-tests Revert "webnn: rename roundingType to outputShapeRounding for pool2d ops" This reverts commit e5811467122a07253805711cf7331c2de1741f1d. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6349833846652928 Sample build with failed test: https://ci.chromium.org/b/8683829578450763649 Affected test(s): [://\:blink_wpt_tests!webtest::virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests#averagePool2d.https.any.html?cpu](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_wpt_tests%21webtest::virtual%2Fwebnn-service-on-cpu%2Fexternal%2Fwpt%2Fwebnn%2Fconformance_tests%23averagePool2d.https.any.html%3Fcpu?q=VHash%3A2dc5f607fec8a763) [://\:blink_wpt_tests!webtest::virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests#maxPool2d.https.any.html?cpu](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_wpt_tests%21webtest::virtual%2Fwebnn-service-on-cpu%2Fexternal%2Fwpt%2Fwebnn%2Fconformance_tests%23maxPool2d.https.any.html%3Fcpu?q=VHash%3A2dc5f607fec8a763) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6349833846652928&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7717139&type=BUG Original change's description: > webnn: rename roundingType to outputShapeRounding for pool2d ops > > This CL renames MLPool2dOptions::roundingType to > MLPool2dOptions::outputShapeRounding in test files and implementations > according to Spec change [1]. > > [1] webmachinelearning/webnn#770 > > Bug: 498118207 > Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 > Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 > Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Auto-Submit: Dai, Feng <feng.dai@intel.com> > Commit-Queue: Dai, Feng <feng.dai@intel.com> > Cr-Commit-Position: refs/heads/main@{#1618021} > Bug: 498118207 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I492d6269e88cfb4b65a22f495a2b73a1168c7747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7783895 Reviewed-by: Alex Gough <ajgo@chromium.org> Owners-Override: Adem Derinel <derinel@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Adem Derinel <derinel@google.com> Reviewed-by: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1618876} -- wpt-commits: b7feb889720d87f1239591a959703cfa2d15f226 wpt-pr: 59407

…8172) Keep original roundingType name for a period of time to ensure backward compatibility. Spec change: webmachinelearning/webnn#770 --------- Co-authored-by: Dwayne Robinson <fdwr@hotmail.com>

…ops" This is a reland of commit e581146. The original CL was reverted because two newly-added baseline files under platform/win11-arm64/virtual/webnn-service-on-cpu/... still referenced the old "roundingType" test names, which no longer matched the renamed WPT cases ("outputShapeRounding"). Those baselines are updated in this reland. Original change's description: > webnn: rename roundingType to outputShapeRounding for pool2d ops > > This CL renames MLPool2dOptions::roundingType to > MLPool2dOptions::outputShapeRounding in test files and implementations > according to Spec change [1]. > > [1] webmachinelearning/webnn#770 > > Bug: 498118207 > Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 > Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 > Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Auto-Submit: Dai, Feng <feng.dai@intel.com> > Commit-Queue: Dai, Feng <feng.dai@intel.com> > Cr-Commit-Position: refs/heads/main@{#1618021} Bug: 498118207 Change-Id: I4df2860081223af43493a0447ca5e69e104950df Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, win11-arm64-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882018 Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Commit-Queue: Dai, Feng <feng.dai@intel.com> Reviewed-by: Elias Klim <elklm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1639919}

…ops" This is a reland of commit e5811467122a07253805711cf7331c2de1741f1d. The original CL was reverted because two newly-added baseline files under platform/win11-arm64/virtual/webnn-service-on-cpu/... still referenced the old "roundingType" test names, which no longer matched the renamed WPT cases ("outputShapeRounding"). Those baselines are updated in this reland. Original change's description: > webnn: rename roundingType to outputShapeRounding for pool2d ops > > This CL renames MLPool2dOptions::roundingType to > MLPool2dOptions::outputShapeRounding in test files and implementations > according to Spec change [1]. > > [1] webmachinelearning/webnn#770 > > Bug: 498118207 > Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 > Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 > Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Auto-Submit: Dai, Feng <feng.dai@intel.com> > Commit-Queue: Dai, Feng <feng.dai@intel.com> > Cr-Commit-Position: refs/heads/main@{#1618021} Bug: 498118207 Change-Id: I4df2860081223af43493a0447ca5e69e104950df Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, win11-arm64-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882018 Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Commit-Queue: Dai, Feng <feng.dai@intel.com> Reviewed-by: Elias Klim <elklm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1639919}

…tputShapeRounding for pool2d ops", a=testonly Automatic update from web-platform-tests Reland "webnn: rename roundingType to outputShapeRounding for pool2d ops" This is a reland of commit e5811467122a07253805711cf7331c2de1741f1d. The original CL was reverted because two newly-added baseline files under platform/win11-arm64/virtual/webnn-service-on-cpu/... still referenced the old "roundingType" test names, which no longer matched the renamed WPT cases ("outputShapeRounding"). Those baselines are updated in this reland. Original change's description: > webnn: rename roundingType to outputShapeRounding for pool2d ops > > This CL renames MLPool2dOptions::roundingType to > MLPool2dOptions::outputShapeRounding in test files and implementations > according to Spec change [1]. > > [1] webmachinelearning/webnn#770 > > Bug: 498118207 > Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 > Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 > Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Auto-Submit: Dai, Feng <feng.dai@intel.com> > Commit-Queue: Dai, Feng <feng.dai@intel.com> > Cr-Commit-Position: refs/heads/main@{#1618021} Bug: 498118207 Change-Id: I4df2860081223af43493a0447ca5e69e104950df Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, win11-arm64-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882018 Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Commit-Queue: Dai, Feng <feng.dai@intel.com> Reviewed-by: Elias Klim <elklm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1639919} -- wpt-commits: 58938037e8fd81f7a51b89985141c39ccf6922b1 wpt-pr: 60329

Remove pool2d MLRoundingType

3c9dd92

fdwr requested review from huningxin and inexorabletash October 23, 2024 23:51

fdwr added 2 commits October 23, 2024 20:25

Merge with main

ce04478

Delete lingering rounding type field definition

fdde61f

huningxin reviewed Oct 24, 2024

View reviewed changes

Comment thread index.bs Outdated

Comment thread index.bs Outdated

inexorabletash reviewed Oct 24, 2024

View reviewed changes

Comment thread index.bs Outdated

anssiko reviewed Nov 5, 2024

View reviewed changes

Comment thread index.bs Outdated

fdwr added 5 commits November 13, 2024 15:59

Bikeshed warnings

2e35d5d

Make outputSizes required

8761da5

Merge with main

9a6bc2e

Nit extra space after required

84d78fe

Revert required dictionary since it causes bikeshed errors

54aacac

fdwr requested a review from huningxin November 15, 2024 23:31

huningxin reviewed Nov 16, 2024

View reviewed changes

Comment thread index.bs Outdated

Comment thread index.bs Outdated

jlewis-austin reviewed Dec 10, 2024

View reviewed changes

fdwr added 6 commits March 10, 2025 00:26

Merge branch 'main' into pool2dNoMLRoundingType

b330e18

Make options required

7a75fb9

Merge branch 'main' into pool2dNoMLRoundingType

cc91b22

Merge branch 'main' into pool2dNoMLRoundingType

01706bd

Merge branch 'main' into pool2dNoMLRoundingType

e4703cf

Updates from review

4f4b6cf

dontcallmedom mentioned this pull request Jul 18, 2025

"string" dfn is now ambiguous w3c/webref#1619

Closed

fdwr added 3 commits July 18, 2025 11:56

Add spec:infra to link-defaults

4439418

Remove optional from MLPool2dOptions

a78e74e

Remove stale algorithm steps after merge

58436c6

anssiko changed the title ~~Remove pool2d MLRoundingType - Simplify the operand layout support of conv2d and pooling 2d operations~~ Rename pool2d MLRoundingType - Simplify the operand layout support of conv2d and pooling 2d operations Sep 4, 2025

huningxin reviewed Sep 23, 2025

View reviewed changes

Comment thread index.bs Outdated

Comment thread index.bs Outdated

Comment thread index.bs Outdated

Comment thread index.bs Outdated

Ningxin's feedback

5115a74

huningxin reviewed Sep 23, 2025

View reviewed changes

Indent calculatedOutput size check

2ee210e

huningxin approved these changes Sep 23, 2025

View reviewed changes

fdwr merged commit a3e8163 into webmachinelearning:main Sep 23, 2025
2 checks passed

dontcallmedom mentioned this pull request Jan 15, 2026

CR Snapshot Update Request for Web Neural Network API - webnn w3c/transitions#769

Closed

anssiko mentioned this pull request Mar 25, 2026

Rename MLPool2dOptions::roundingType -> MLPool2dOptions::outputShapeRounding web-platform-tests/wpt#58747

Closed

chromium-wpt-export-bot mentioned this pull request Apr 13, 2026

webnn: rename roundingType to outputShapeRounding for pool2d ops web-platform-tests/wpt#59145

Merged

This was referenced Apr 22, 2026

Rename roundingType to outputShapeRounding for pool2d ops webmachinelearning/webnn-samples#341

Merged

[WebNN] Rename roundingType to outputShapeRounding for pool2d ops microsoft/onnxruntime#28172

Merged

chromium-wpt-export-bot mentioned this pull request Apr 22, 2026

Revert "webnn: rename roundingType to outputShapeRounding for pool2d ops" web-platform-tests/wpt#59407

Merged

chromium-wpt-export-bot mentioned this pull request Jun 1, 2026

Reland "webnn: rename roundingType to outputShapeRounding for pool2d ops" web-platform-tests/wpt#60329

Merged

Uh oh!

Conversation

fdwr commented Oct 23, 2024 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional changes:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlewis-austin Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

fdwr Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

inexorabletash commented Feb 25, 2025

Uh oh!

inexorabletash commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fdwr commented Jul 18, 2025

Uh oh!

dontcallmedom commented Jul 18, 2025

Uh oh!

fdwr commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huningxin Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fdwr Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

huningxin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fdwr commented Oct 23, 2024 •

edited by pr-preview Bot

Loading

inexorabletash commented Feb 25, 2025 •

edited

Loading

fdwr commented Sep 11, 2025 •

edited

Loading

huningxin Sep 23, 2025 •

edited

Loading