Add int64, uint64 data type support for reduceL1, reduceProduct, reduceSum and reduceSumSquare - #750
Closed
shiyi9801 wants to merge 1 commit into
Closed
Add int64, uint64 data type support for reduceL1, reduceProduct, reduceSum and reduceSumSquare#750shiyi9801 wants to merge 1 commit into
shiyi9801 wants to merge 1 commit into
Conversation
Contributor
Author
|
Current Chromium implementation allows int64/uint64 for these reduce ops, so I think we should either change the spec or the implementation. PTAL, thanks :) @huningxin @fdwr |
fdwr
approved these changes
Aug 15, 2024
fdwr
left a comment
Collaborator
There was a problem hiding this comment.
opSupportLimits for CoreML will be negative for these ops, but LGTM. Thanks for spotting the difference.
Contributor
|
Thanks @shiyi9801 , is this PR duplicated by #695? |
Collaborator
Aah yes, that did look familiar. |
Contributor
Author
Oh I didn't notice there is already a PR to fix this, yes it is duplicated, please continue yours :) I'll drop this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #694
Preview | Diff