Skip to content

Fix onFirstUse this binding #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avaer merged 2 commits into from
Jan 29, 2022
Merged

Fix onFirstUse this binding #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbe3e33
Hack onFirstUse call
Jan 29, 2022
b791a83
Rebuild
Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions build/three.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14111,7 +14111,7 @@
this.getUniforms = function () {
if (cachedUniforms === undefined) {
// Populates cachedUniforms and cachedAttributes
onFirstUse();
onFirstUse.call(this);
}

return cachedUniforms;
Expand All @@ -14123,7 +14123,7 @@
this.getAttributes = function () {
if (cachedAttributes === undefined) {
// Populates cachedAttributes and cachedUniforms
onFirstUse();
onFirstUse.call(this);
}

return cachedAttributes;
Expand Down Expand Up @@ -34150,15 +34150,15 @@
// TODO: delete this comment?
const distanceGeometry = new THREE.IcosahedronBufferGeometry( 1, 2 );
const distanceMaterial = new THREE.MeshBasicMaterial( { color: hexColor, fog: false, wireframe: true, opacity: 0.1, transparent: true } );
this.lightSphere = new THREE.Mesh( bulbGeometry, bulbMaterial );
this.lightSphere = new THREE.Mesh( bulbGeometry, bulbMaterial );
this.lightDistance = new THREE.Mesh( distanceGeometry, distanceMaterial );
const d = light.distance;
if ( d === 0.0 ) {
this.lightDistance.visible = false;
} else {
this.lightDistance.scale.set( d, d, d );
}
this.add( this.lightDistance );
const d = light.distance;
if ( d === 0.0 ) {
this.lightDistance.visible = false;
} else {
this.lightDistance.scale.set( d, d, d );
}
this.add( this.lightDistance );
*/
}

Expand All @@ -34175,12 +34175,12 @@
}
/*
const d = this.light.distance;
if ( d === 0.0 ) {
this.lightDistance.visible = false;
} else {
this.lightDistance.visible = true;
if ( d === 0.0 ) {
this.lightDistance.visible = false;
} else {
this.lightDistance.visible = true;
this.lightDistance.scale.set( d, d, d );
}
}
*/

}
Expand Down Expand Up @@ -34579,7 +34579,7 @@
1/___0/|
| 6__|_7
2/___3/
0: max.x, max.y, max.z
0: max.x, max.y, max.z
1: min.x, max.y, max.z
2: min.x, min.y, max.z
3: max.x, min.y, max.z
Expand Down
2 changes: 1 addition & 1 deletion build/three.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions build/three.module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18695,7 +18695,7 @@ function WebGLProgram( renderer, cacheKey, parameters, bindingStates ) {
if ( cachedUniforms === undefined ) {

// Populates cachedUniforms and cachedAttributes
onFirstUse();
onFirstUse.call(this);

}

Expand All @@ -18712,7 +18712,7 @@ function WebGLProgram( renderer, cacheKey, parameters, bindingStates ) {
if ( cachedAttributes === undefined ) {

// Populates cachedAttributes and cachedUniforms
onFirstUse();
onFirstUse.call(this);

}

Expand Down
4 changes: 2 additions & 2 deletions src/renderers/webgl/WebGLProgram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,7 @@ function WebGLProgram( renderer, cacheKey, parameters, bindingStates ) {
if ( cachedUniforms === undefined ) {

// Populates cachedUniforms and cachedAttributes
onFirstUse();
onFirstUse.call(this);

}

Expand All @@ -856,7 +856,7 @@ function WebGLProgram( renderer, cacheKey, parameters, bindingStates ) {
if ( cachedAttributes === undefined ) {

// Populates cachedAttributes and cachedUniforms
onFirstUse();
onFirstUse.call(this);

}

Expand Down