Skip to content

Fix Linux HUD input handling#157

Merged
webadderall merged 1 commit into
webadderallorg:mainfrom
iRaziul:main
Apr 3, 2026
Merged

Fix Linux HUD input handling#157
webadderall merged 1 commit into
webadderallorg:mainfrom
iRaziul:main

Conversation

@iRaziul
Copy link
Copy Markdown
Contributor

@iRaziul iRaziul commented Apr 2, 2026

Summary

  • disable HUD mouse passthrough on Linux where Electron's forwarded hover path leaves the transparent overlay permanently click-through
  • keep the existing passthrough behavior on macOS and Windows
  • preserve the renderer-side hover toggles while forcing the Linux HUD window to remain interactive

Verification

  • npx tsc --noEmit

Summary by CodeRabbit

  • Bug Fixes
    • Improved HUD overlay mouse passthrough behavior by preventing activation on unsupported platforms.
    • Enhanced platform-specific compatibility checks for more reliable mouse interaction handling.
    • Refined mouse event control flow for consistent cross-platform overlay behavior.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 2, 2026

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "*" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cc9755da-2e62-4443-b5ca-7b6705d9a461

📥 Commits

Reviewing files that changed from the base of the PR and between 4d29baa and 168d230.

📒 Files selected for processing (1)
  • electron/windows.ts

📝 Walkthrough

Walkthrough

Added platform capability check for HUD overlay mouse passthrough support to prevent enabling on unsupported platforms. Updated IPC handler with early return logic when unsupported. Modified window creation to make initial mouse passthrough opt-in, conditional on platform support.

Changes

Cohort / File(s) Summary
HUD Overlay Mouse Passthrough Platform Support
electron/windows.ts
Introduced isHudOverlayMousePassthroughSupported platform check. Updated IPC handler to explicitly disable mouse passthrough on unsupported platforms with early return. Refined control flow with conditional early returns for ignore-mouse logic. Made initial passthrough in window creation opt-in based on platform capability.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Through platforms vast, the bunny hops,
Mouse passthrough logic never stops,
With checks both swift and platform-aware,
The HUD overlay floats with care!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description provides purpose and problem context but lacks required template sections like Type of Change, Related Issues, Testing Guide, and self-review checklist. Complete the PR template by selecting Type of Change, linking related issues, providing a Testing Guide with steps to verify the fix, and confirming self-review completion.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main platform-specific fix applied in this changeset: addressing Linux HUD input handling issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants