WebNN: Support rankRange for op output tensors in opSupportLimits - #54904
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
September 18, 2025 01:34
This CL prototypes WebNN spec change [1] that supports tensor rank range for graph input, constant, output and each operation's output. This CL adds new shape rank validation according to allowed output tensor rank of expand and reshape operations. The sequence output of gru and cell operations has different rank, this CL extends context properties to support them. For logical ops, the output rank ranges are set to each op's input rank ranges, while the output data types are set to unified logical output data type of context properties. [1]: webmachinelearning/webnn#857 Bug: 442209350 Change-Id: Ie5ca5c794cebb4586bcccaaa8d237be1dffea458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6903617 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1516982}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6903617
branch
from
September 18, 2025 01:34
c6c5603 to
c9c3a0c
Compare
wpt-pr-bot
approved these changes
Sep 18, 2025
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL prototypes WebNN spec change 1 that supports tensor rank
range for graph input, constant, output and each operation's output.
This CL adds new shape rank validation according to allowed output
tensor rank of expand and reshape operations.
The sequence output of gru and cell operations has different rank,
this CL extends context properties to support them.
For logical ops, the output rank ranges are set to each op's input
rank ranges, while the output data types are set to unified logical
output data type of context properties.
Bug: 442209350
Change-Id: Ie5ca5c794cebb4586bcccaaa8d237be1dffea458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6903617
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1516982}