Skip to content

Fix linux appimage task#4644

Merged
leaanthony merged 2 commits intowailsapp:v3-alphafrom
COD3HUNT3R:v3-alpha
Oct 13, 2025
Merged

Fix linux appimage task#4644
leaanthony merged 2 commits intowailsapp:v3-alphafrom
COD3HUNT3R:v3-alpha

Conversation

@COD3HUNT3R
Copy link
Copy Markdown

@COD3HUNT3R COD3HUNT3R commented Oct 13, 2025

Currently appimage builds are broken as per #4641

This fixes appimage builds.

Summary by CodeRabbit

  • Bug Fixes

    • AppImage now uses the correct app-specific icon, improving how the app appears in desktop environments, launchers, and file managers and avoiding icon conflicts across builds.
  • Chores

    • Build process updated to dynamically name the app icon from the application name, ensuring consistent branding for generated AppImages.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 13, 2025

Walkthrough

Updated the Linux Taskfile to make the AppImage icon filename dynamic by using {{.APP_NAME}}. The create:appimage task now copies ../../appicon.png to {{.APP_NAME}}.png and sets ICON to {{.APP_NAME}}.png instead of a fixed ../../appicon.png.

Changes

Cohort / File(s) Summary
Linux AppImage icon naming
v3/internal/commands/build_assets/linux/Taskfile.yml
In create:appimage: copy destination changed to {{.APP_NAME}}.png (was appicon.png); ICON set to {{.APP_NAME}}.png (was ../../appicon.png).
Changelog
v3/UNRELEASED_CHANGELOG.md
Added a Fixed entry describing the Linux Taskfile AppImage icon variable fix referencing PR #4644.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Bug, Linux, size:XS

Suggested reviewers

  • leaanthony

Poem

I nibble bytes with whiskers bright,
Renamed the icon to shine just right.
From static PNG to APP_NAME's glow,
AppImage now wears the name we know.
Hop, commit, and off we go! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description does not follow the required template, as it lacks a detailed summary with the issue number reference, does not specify the type of change, omits the testing steps and configuration section, and missing the checklist and changelog update confirmation. Please update the description to include the summary with “Fixes #”, fill in the type of change checklist, provide detailed testing instructions and environment, and complete the repository’s checklist including changelog updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary change by indicating the Linux AppImage task has been fixed and directly reflects the main purpose of the pull request without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Oct 13, 2025
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
v3/UNRELEASED_CHANGELOG.md (1)

26-26: Capitalize proper nouns and align reference style with examples.

Use "AppImage" and "Taskfile", and prefer "(#4644)" to match examples below.

-- Fix Linux appimage appicon variable in Linux taskfile [PR #4644](https://github.com/wailsapp/wails/pull/4644)
+- Fix Linux AppImage icon filename handling in Linux Taskfile (#4644)
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42eef03 and 78c4ce1.

📒 Files selected for processing (1)
  • v3/UNRELEASED_CHANGELOG.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Run Go Tests v3 (macos-latest, 1.24)
  • GitHub Check: Run Go Tests v3 (windows-latest, 1.24)
  • GitHub Check: Run Go Tests v3 (ubuntu-latest, 1.24)
  • GitHub Check: semgrep-cloud-platform/scan

@leaanthony leaanthony merged commit 0f23972 into wailsapp:v3-alpha Oct 13, 2025
68 checks passed
@leaanthony
Copy link
Copy Markdown
Member

Thanks @COD3HUNT3R 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Documentation Improvements or additions to documentation v3-alpha

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants