fix: user-defined providers take precedence over built-in providers#234
Merged
asdek merged 1 commit intovxcontrol:mainfrom Apr 8, 2026
Merged
Conversation
|
#233 related ? |
Contributor
|
@octo-patch Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220
Problem
GetProvider()inbackend/pkg/providers/providers.gochecked built-in providers first via aswitchstatement on the provider name. If the user-defined provider shared a name with a built-in one (e.g."qwen"), the switch matched and returned the built-in provider, ignoring the user's custom configuration in the database.Solution
Reverse the lookup order in
GetProvider():sql.ErrNoRowsis not returned), build and return that provider — it takes precedence.sql.ErrNoRows), fall back to the built-in provider switch.This ensures that user-configured providers always override the defaults, regardless of whether the name matches a built-in provider.
Testing
Manually verified the logic flow:
"qwen"exists in the DB,GetUserProviderByNamereturns it and the function returns the user-built provider without entering the switch.sql.ErrNoRowscauses the function to fall through to the built-in switch, preserving existing behavior for all other provider names.