-
Notifications
You must be signed in to change notification settings - Fork 113
Feature: Add methods to PVectorMut similar to std::vec::Vec
#5079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f547b26 to
8afab09
Compare
a5c50d5 to
5de123a
Compare
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
70b726f to
854e811
Compare
PVec similar to std::vec::VecPVectorMut similar to std::vec::Vec
CodSpeed Performance ReportMerging #5079 will degrade performances by 37.81%Comparing Summary
Benchmarks breakdownFootnotes
|
628c45a to
a39d612
Compare
a39d612 to
e43dbbf
Compare
deb52da to
06c6d20
Compare
06c6d20 to
5ebaa5e
Compare
Deploying vortex-bench with
|
| Latest commit: |
5ebaa5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9006aa31.vortex-93b.pages.dev |
| Branch Preview URL: | https://ct-vv-methods.vortex-93b.pages.dev |
e9ef943 to
f3fa13d
Compare
f3fa13d to
f028c8e
Compare
Signed-off-by: Connor Tsui <[email protected]>
f028c8e to
fcafdd5
Compare
Tracking Issue: #5028
Adds methods to
PVecthat are similar in nature to the methods available on the standard libraryVecimplementation.Note that none of these are strictly necessary right now, but I wanted to have this now so we can write more meaningful tests (instead of ones that just track metadata like length and capacity).
I want to add these methods in the future, but they should probably come in a separate PR:
into_iterretain(that takes aFn(Option<&T>) -> boolinstead ofFn(&T) -> boolretain_mut(similar to above but&mut Tretain_indices(we can use this to implement filter for primitive arrays)extend_from_slice(a nice to have because we know the exact length of the slice and don't have to do all the weird iterator size hint stuff)copy_withinfill_rangedrain(maybe we don't need this but I can see it being useful)splice(same)removeswap_removeThere are others, but probably a lot less important