vdk-audit: set python requires >= 3.8#1289
Merged
antoniivanov merged 1 commit intomainfrom Nov 3, 2022
Merged
Conversation
vdk-audit hook works only with 3.8 python or newer. We want to prevent the vdk-audit from being installed on older python version. Setting the python_requires argument to the appropriate PEP 440 version specifier string will prevent pip from installing the project on other Python versions Testing Done: `pip install -e ./vdk-audit` failed correctly with "ERROR: Package 'vdk-audit' requires a different Python: 3.7.9 not in '>=3.8'" Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
mivanov1988
approved these changes
Nov 3, 2022
murphp15
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vdk-audit hook works only with 3.8 python or newer. We want to prevent the vdk-audit from being installed on older python version.
Setting the python_requires argument to the appropriate PEP 440 version specifier string will prevent pip from installing the project on other Python versions
Testing Done:
pip install -e ./vdk-auditfailed correctly with "ERROR: Package 'vdk-audit' requires a different Python: 3.7.9 not in '>=3.8'"Signed-off-by: Antoni Ivanov aivanov@vmware.com