vdk-core: resolve library error classification on startup#1241
Merged
Conversation
murphp15
approved these changes
Oct 17, 2022
ivakoleva
reviewed
Oct 25, 2022
murphp15
reviewed
Nov 7, 2022
ivakoleva
reviewed
Nov 8, 2022
ivakoleva
approved these changes
Nov 11, 2022
Contributor
ivakoleva
left a comment
There was a problem hiding this comment.
I am okay to merge, my main concern about design still is described in a comment about why doesn't plugin_load_success exist into plugin_registry. Lets elaborate before merging
ivakoleva
reviewed
Nov 11, 2022
05bac83 to
af28805
Compare
antoniivanov
approved these changes
Nov 11, 2022
added 15 commits
November 11, 2022 16:50
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
af28805 to
5d6fd77
Compare
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what: Added functionality which handles ImportErrors, logs the error and writes
termination message via the appropriate internal plugin implementation and exits.
Other approaches tried:
a bit further in the call chain, however tests failed (see previous pipelines in this pull req)
why: some user data jobs have been failing with ImportErrors (where a
user import clashes with internal imports, however this crashed the
vdk runtime without writing a termination message.
testing: added unit test.
Signed-off-by: mrMoZ1 mzhivkov@vmware.com