refactor: move gateway modules from agentic-core to agentic-server#35
Conversation
Move proxy, readiness, config, and error modules from agentic-core to agentic-server since they are gateway-specific concerns. Migrate all crate Cargo.tomls to use workspace-level dependency declarations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
b32a447 to
0769d19
Compare
There was a problem hiding this comment.
Looks good — moving the proxy stuff to agentic-server makes sense since it's all gateway-specific right now.
One thing — PR #33 is adding the store layer which should probably land in agentic-core (it's the framework-agnostic stuff from ADR-03). With this emptying core out, just want to make sure the two PRs don't step on each other around lib.rs. Probably fine since yours just leaves the placeholder comment, but figured I'd flag it.
There was a problem hiding this comment.
Makes sense to keep this alive. Might be worth updating the comment to hint at what's coming (store traits, executor, step functions) so future contributors know this isn't dead code.
There was a problem hiding this comment.
Good call — updated the comment to hint at what's coming.
…boundary Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> # Conflicts: # crates/agentic-server/Cargo.toml # crates/agentic-server/src/app.rs
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
left a comment
There was a problem hiding this comment.
Thanks for flagging — we expect this PR to merge before #33, so it should be a clean base for the store layer to land on top of.
|
@maralbahari @franciscojavierarceo this goes against ADR3, we have agentic-core containing all functions, proxy_request is a framework agnostic request, takes a payload and passes to the inference backend, if we put in the server now praxis (or any other gw) has to bring the axum dep too and it’s not what we want. thanks! can we revert? |
|
yeah sorry @leseb |
|
@maralbahari we can discuss more in slack (or here too of course) |
## Summary - Adds `[workspace.dependencies]` to root `Cargo.toml` and switches all three crates to `dep.workspace = true` - This is the non-reverted portion of #35 — dependency centralisation only, no module moves - No behavioral changes; all code stays where it is ## Test plan - [x] `cargo build` — clean - [x] `cargo test` — all pass - [x] `cargo clippy --all-targets -- -D warnings` — clean - [x] `cargo fmt -- --check` — clean - [x] `pre-commit run --all-files` — all hooks pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
proxy.rs,readiness.rs,config.rs, anderror.rsfromagentic-coretoagentic-server— these are gateway-specific concerns, not framework-agnostic core abstractionsConfig→GatewayConfigto clarify the struct's scopeCargo.tomlfiles to use[workspace.dependencies]declarationsTest Plan
cargo build— cleancargo test— 25/25 passcargo clippy --all-targets -- -D warnings— cleancargo fmt -- --check— clean🤖 Generated with Claude Code