fix(coverage): browser mode + `coverage.all` by AriPerkkio · Pull Request #7597 · vitest-dev/vitest

AriPerkkio · 2025-03-02T09:01:19Z

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

pkg-pr-new · 2025-03-02T09:03:32Z

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7597

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7597

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7597

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7597

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7597

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7597

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7597

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7597

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7597

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7597

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7597

vite-node

npm i https://pkg.pr.new/vite-node@7597

vitest

npm i https://pkg.pr.new/vitest@7597

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7597

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7597

commit: e653bec

netlify · 2025-03-02T09:04:22Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`e653bec`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/67d04ffe5dc8590008bda006
😎 Deploy Preview	https://deploy-preview-7597--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AriPerkkio

Alright the Windows issues are finally resolved. @mrginglymus could you do one final check with https://pkg.pr.new/vitest@12d473c and equivalent preview packages with your real-world project?

AriPerkkio · 2025-03-08T14:17:24Z

+        // On Windows root doesn't start with "/" while filenames do
+        if (!filename.startsWith(root) && !filename.startsWith(`/${root}`)) {


On Windows the root is here D:/a/vitest/vitest/test/coverage-test while filename is /D:/a/vitest/vitest/test/coverage-test/fixtures/src/untested-file.ts.

AriPerkkio · 2025-03-10T08:22:57Z

/ecosystem-ci run

vitest-ecosystem-ci · 2025-03-10T08:23:21Z

📝 Ran ecosystem CI: Open

suite	result
aria-live-capture	✅ success
nuxt	❌ failure
nuxt-test-utils	✅ success
elk	✅ success
effect	❌ failure
lerna-lite	✅ success
zustand	✅ success
vue	✅ success
vite	✅ success
vitest-vscode	✅ success
vitest-sonar-reporter	✅ success
vitest-browser-examples	✅ success
vitest-coverage-large	✅ success
vitest-reporters-large	✅ success
vitest-benchmark-large	✅ success

mrginglymus · 2025-03-10T08:42:10Z

Alright the Windows issues are finally resolved. @mrginglymus could you do one final check with https://pkg.pr.new/vitest@12d473c and equivalent preview packages with your real-world project?

@AriPerkkio yes this is working correctly on my real-world project. Thanks so much for the effort in fixing this!

hi-ogawa

Looks good to me 👍
How did you eventually fix optimize deps error? Is it by switching vitenode.transformRequest with browser.transformRequest #7597 (comment)?

AriPerkkio · 2025-03-13T07:12:13Z

How did you eventually fix optimize deps error? Is it by switching vitenode.transformRequest with browser.transformRequest #7597 (comment)?

Switching to vitenode.transformRequest is a way to avoid it, yes.

But when using browser, this change was enough to fix it. And when doing parallel requests, it was important not to reset noDiscovery back.

+ browser.config.optimizeDeps.noDiscovery = true
const result = await browser?.transformRequest(filename).catch(() => null)

Setting the server.preTransformRequests had no effect at all - Vite was still following dependencies of requested modules. 🤷

hi-ogawa · 2025-03-13T07:23:26Z

But, if this relies on vite node's server and browser mode's server being different, would it potentially block the plan of merging the server? #6912

sheremet-va · 2025-03-13T12:16:52Z

But, if this relies on vite node's server and browser mode's server being different, would it potentially block the plan of merging the server? #6912

How does it matter though? The code output is the same, isn't it what matters here?

hi-ogawa · 2025-03-13T23:24:08Z

I thought the difference is vite-node's server explicitly configures optimizeDeps.noDiscovery: true + preTransformRequests: false, but browser's server has opposite (i.e. normal Vite app default).

sheremet-va · 2025-03-14T06:19:24Z

I thought the difference is vite-node's server explicitly configures optimizeDeps.noDiscovery: true + preTransformRequests: false, but browser's server has opposite (i.e. normal Vite app default).

Yes, but does it matter for coverage what these options are?

hi-ogawa · 2025-03-14T08:53:12Z

I thought the difference is vite-node's server explicitly configures optimizeDeps.noDiscovery: true + preTransformRequests: false, but browser's server has opposite (i.e. normal Vite app default).

Yes, but does it matter for coverage what these options are?

I would imagine transformRequest output is same, but as Ari said #7597 (comment), without noDiscovery, Vite server would eagerly crawl and potentially trigger optimize deps, so such side effect is not ideal for our usage of transformRequest for coverage.all.
(actually I don't know what's bad about this, but at least, optimize deps might show odd error/warning from esbuild?)

I think it's good to land with vitenode.transformRequest, but we might need to revisit this when #6912. I don't know whether we need something new from Vite or we can use extra inline environment for this transform, or something else.

AriPerkkio added the cr-tracked label Mar 2, 2025

AriPerkkio force-pushed the fix/browser-mode-coverage-all branch from 85550bc to 874d14d Compare March 4, 2025 08:25

AriPerkkio mentioned this pull request Mar 4, 2025

Import conditions not respected on main thread #7588

Closed

6 tasks

AriPerkkio force-pushed the fix/browser-mode-coverage-all branch from a2a5043 to 272ae0d Compare March 4, 2025 14:36

AriPerkkio commented Mar 6, 2025

View reviewed changes

Comment thread packages/vitest/src/utils/coverage.ts Outdated

AriPerkkio force-pushed the fix/browser-mode-coverage-all branch 13 times, most recently from 2208f7d to 12d473c Compare March 8, 2025 13:55

AriPerkkio commented Mar 8, 2025

View reviewed changes

Comment thread packages/vitest/src/utils/coverage.ts Outdated

AriPerkkio marked this pull request as ready for review March 8, 2025 14:21

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

sheremet-va requested changes Mar 11, 2025

View reviewed changes

Comment thread packages/vitest/src/utils/coverage.ts Outdated

test: update snapshots

168373d

AriPerkkio added 4 commits March 11, 2025 16:44

fix(coverage): browser mode + coverage.all

7ab21cf

test: coverage.all + conditional alias

b026964

fix(coverage): v8 use correct transform for uncovered files

b896d29

fix: transform with vitenode instead of browser.vite

e653bec

AriPerkkio force-pushed the fix/browser-mode-coverage-all branch from 03cd06b to e653bec Compare March 11, 2025 15:00

sheremet-va approved these changes Mar 11, 2025

View reviewed changes

hi-ogawa approved these changes Mar 13, 2025

View reviewed changes

sheremet-va merged commit 422ba66 into vitest-dev:main Mar 17, 2025

AriPerkkio deleted the fix/browser-mode-coverage-all branch March 17, 2025 11:54

tvanier mentioned this pull request Mar 17, 2025

chore(deps-dev): bump vitest from 3.0.8 to 3.0.9 tvanier/sport-visioner#584

Merged

renovate Bot mentioned this pull request Mar 19, 2025

chore: bump up all non-major dependencies toeverything/AFFiNE#10920

Merged

1 task

This was referenced Apr 30, 2025

chore(deps): update all dependencies radashi-org/radashi#282

Open

fix: update package dependencies adbayb/clean-architecture#8

Merged

renovate Bot mentioned this pull request Jun 23, 2025

chore(deps): update devdependencies (major) ReoHakase/mystack-discord-bot#16

Open

1 task

		// On Windows root doesn't start with "/" while filenames do
		if (!filename.startsWith(root) && !filename.startsWith(`/${root}`)) {

Uh oh!

Uh oh!

Conversation

AriPerkkio commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

pkg-pr-new Bot commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

Uh oh!

AriPerkkio left a comment

Choose a reason for hiding this comment

Uh oh!

AriPerkkio Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as resolved.

AriPerkkio commented Mar 10, 2025

Uh oh!

vitest-ecosystem-ci Bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrginglymus commented Mar 10, 2025

Uh oh!

Uh oh!

hi-ogawa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AriPerkkio commented Mar 13, 2025

Uh oh!

hi-ogawa commented Mar 13, 2025

Uh oh!

sheremet-va commented Mar 13, 2025

Uh oh!

hi-ogawa commented Mar 13, 2025

Uh oh!

sheremet-va commented Mar 14, 2025

Uh oh!

hi-ogawa commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AriPerkkio commented Mar 2, 2025 •

edited

Loading

pkg-pr-new Bot commented Mar 2, 2025 •

edited

Loading

netlify Bot commented Mar 2, 2025 •

edited

Loading

vitest-ecosystem-ci Bot commented Mar 10, 2025 •

edited

Loading

hi-ogawa left a comment •

edited

Loading

hi-ogawa commented Mar 14, 2025 •

edited

Loading