Update verification request banner#38
Merged
viktorstrate merged 1 commit intoviktorstrate:mainfrom Feb 17, 2026
Merged
Conversation
Contributor
|
FWIW, I think it's important to let the client re-request verification. (To not disable/remove the button once it's been requested.) If the other end accidentally dismisses the process, there's no way to recover, otherwise. Also, when verification fails, it would be nice to reset the UI. I had a partially-complete branch worked up here that you might be able to borrow from, if you like. |
Contributor
Author
Good point, I'll revise this to let the button be visible at all times. |
When you press Verify session in Mactrix, a request is sent, but there is no visual feedback to the user that the request has been made. To address this, an internal state variable was added to check whether the button was pressed and, when successful, display a progress view indicating that it had sent the request to a user's trusted devices. The banner label has also been altered to give more information to the user on what to do and why the verification is important. Fixes viktorstrate#29.
e2039e5 to
8bef133
Compare
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you press Verify session in Mactrix, a request is sent, but there is no visual feedback to the user that the request has been made. To address this, an internal state variable was added to check whether the button was pressed and, when successful, display a progress view indicating that it had sent the request to a user's trusted devices.
The banner label has also been altered to give more information to the user on what to do and why the verification is important.
Fixes #29.