-
-
Notifications
You must be signed in to change notification settings - Fork 179
Small fixes for typos and clarity #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f223f05
f9a17b3
0ef8ae7
cd15715
791687f
cf2a92c
bab8763
a515a4f
26acb71
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -180,7 +180,7 @@ Describe 'Hashtables' { | |
| $Hashtable.ContainsValue('Fruit') | Should -BeTrue | ||
|
|
||
| $Hashtable['Oranges'] | Should -Be 'Fruit' | ||
| $Hashtable['Carrots'] | Should -Not -Be $Hashtable['Oranges'] | ||
| $Hashtable['Carrots'] | Should -Be $Hashtable['Oranges'] | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might need more clarification, for sure, but I don't think this is the problem here. The conditions as set without changing this line are that the hashtable must:
The intended solution is for carrots to be marked as Is there a way we can make that a bit more clear for this koan? |
||
| } | ||
|
|
||
| It 'will not implicitly convert keys and lookup values' { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -125,7 +125,7 @@ Describe 'Pipelines and Loops' { | |
| #> | ||
| $i | ||
| } | ||
| $Values | Should -Be @(0, 1, 2, 3, 4) | ||
| $Values | Should -Be __ | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm. I tend to prefer that blanks take a similar form to what's expected; we're expecting an array here, so a single blank is a bit misleading imo. Perhaps something like this would be better? $ExpectedValues = @(
__
__
__
__
__
)
$ExpectedValues | Should -Be $Values |
||
| } | ||
|
|
||
| It 'can loop while a condition is $true' { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,23 +67,23 @@ Describe 'Kata - Sorting Characters' { | |
| } | ||
| @{ | ||
| String = 'What do you call the world?' | ||
| Result = 'aacddehhlllooorttuwWy' | ||
| Result = 'aacddehhlllooorttuWwy' | ||
| } | ||
| @{ | ||
| String = 'Out of nowhere, the mind comes forth.' | ||
| Result = 'cdeeeeffhhhimmnnooOoorrstttuw' | ||
| Result = 'cdeeeeffhhhimmnnOoooorrstttuw' | ||
| } | ||
| @{ | ||
| String = 'Because it is so very clear, it takes longer to come to the realization.' | ||
| Result = 'aaaaaBccceeeeeeeeeghiiiiiklllmnnoooooorrrrsssstttttttuvyz' | ||
| } | ||
| @{ | ||
| String = 'The hands of the world are open.' | ||
| Result = 'aaddeeeefhhhlnnoooprrstTw' | ||
| Result = 'aaddeeeefhhhlnnoooprrsTtw' | ||
| } | ||
| @{ | ||
| String = 'You are those huge waves sweeping everything before them, swallowing all in their path.' | ||
| Result = 'aaaaabeeeeeeeeeeeefgggghhhhhhiiiiillllmnnnnoooopprrrrsssstttttuuvvwwwwyY' | ||
| Result = 'aaaaabeeeeeeeeeeeefgggghhhhhhiiiiillllmnnnnoooopprrrrsssstttttuuvvwwwwYy' | ||
|
Comment on lines
+70
to
+86
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you share the code you used to get these results? I remember what I did to get the result I laid out in there, but there's a good chance it didn't play nice with the upper and lower cases. This looks right, just want to verify :) |
||
| } | ||
| ) | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEMP:as a pre-existing PSDrive doesn't exist until PS6 or 7 I think?TestDrive:is provided by Pester and cleans up after itself without us having to do any manual work to do so. Was this one not working for you? 🙂