Skip to content

Refactor Introduction Koans #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vexx32 merged 6 commits into from
Mar 5, 2020
Merged

Refactor Introduction Koans #370

vexx32 merged 6 commits into from
Mar 5, 2020

Conversation

@vexx32
Copy link
Owner

@vexx32 vexx32 commented Mar 5, 2020 •
edited
Loading

PR Summary

Update some of the introductory topics, cleanup comments and refactor a couple of the koans mainly in the introductions section.

Changes

  • Refactor AboutArrays commentary and a couple of the koans
  • Refactor AboutAssertions introductory text
  • Refactor AboutBinary introductory comments and koans
  • Refactor AboutBooleans introductory comments
  • Refactor AboutNumbers commentary and add a koan or two
  • Refactor AboutStrings commentary and adjust a couple of koans slightly.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Koans Invoking the Great Doubt labels Mar 5, 2020
@vexx32 vexx32 requested a review from steviecoaster as a code owner March 5, 2020 05:04
@vexx32 vexx32 changed the title Koans/introduction/qa pass Refactor Introduction Koans Mar 5, 2020
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Mar 5, 2020
@vexx32 vexx32 merged commit 4baabcd into master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees

No one assigned

Labels

Category-Koans Invoking the Great Doubt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vexx32